Support aborted build status reporting #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tension - also add integration tests
- this helps handle nulls
[JENKINS-28139] Hook payload parse extension point
admin:repo_hook mention in help
handle exceptions of extensions
[FIXED JENKINS-36144] Borrow the SCMTrigger's queue
…nk (jenkinsci#128) Most git repository browsing systems (bitbucket, cgit, github, gitweb) display a short form of the SHA1 (commonly the first 7 characters) with a clickable hyperlink that will take them to a page that includes the full SHA1. This change reduces the visible SHA1 text in the list of changes to the first 7 characters of the SHA1, consistent with those other repository browsers. It also adds assertions that the expected format is used and simplifies the existing annotator tests.
* Create NOTICE.md * rm notice information from readme
…itory_source Manually entered repository source
add some override annotations in ghcommitnotifier
Member
|
does jenkins call publishers on aborted build? Don't think so. |
Member
No, it doesn't. AFAIK |
Author
|
The behavior that I'm seeing that is when a build starts, a pending github commit status is created. When the build is aborted, another pending github commit status is created. I believe that second status is pending because it is the default status. It does appear that the github plugin is getting called for an aborted build. |
Member
|
please provide a test to reproduce (you can find examples with mocked github in tests for notifier) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request supports reporting aborted builds to Github as errors. Currently, aborted builds use the default status which is pending. This can be confusing for automated tools.
This change is