-
Notifications
You must be signed in to change notification settings - Fork 402
Description
Result.ABORTED is not supported by DefaultStatusResultSource. I've tried to implement a fix here #133. However, it doesn't appear that Result.ABORTED is going to work properly with the current isBetterThanOrEqual logic because ABORTED has the greatest value.
As a general note, I'm also confused why this isBetterThanOrEqualTo logic was used in the first place. It seems like a mapping of Result to GHCommitStatus would suffice.
Originally reported by
kpike, imported from: Aborted builds are reported as pending to Github
- assignee:
lanwen
- status: Open
- priority: Minor
- component(s): github-plugin
- resolution: Unresolved
- votes: 1
- watchers: 1
- imported: 2025-12-08
Raw content of original issue
Result.ABORTED is not supported by DefaultStatusResultSource. I've tried to implement a fix here #133. However, it doesn't appear that Result.ABORTED is going to work properly with the current isBetterThanOrEqual logic because ABORTED has the greatest value.
As a general note, I'm also confused why this isBetterThanOrEqualTo logic was used in the first place. It seems like a mapping of Result to GHCommitStatus would suffice.