Skip to content

Fix typo: ENCODE_BY_LITTEL_ENDIAN → ENCODE_BY_LITTLE_ENDIAN #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ithewei merged 3 commits into from
Mar 30, 2026
Merged

Fix typo: ENCODE_BY_LITTEL_ENDIAN → ENCODE_BY_LITTLE_ENDIAN #825

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ac85a6
Initial plan
Copilot Mar 30, 2026
8008a8f
Fix typo: ENCODE_BY_LITTEL_ENDIAN → ENCODE_BY_LITTLE_ENDIAN
Copilot Mar 30, 2026
c7a8e4e
Remove backward compatibility for little endian encoding
ithewei Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion event/hloop.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ typedef enum {
// UNPACK_BY_LENGTH_FIELD
typedef enum {
ENCODE_BY_VARINT = 17, // 1 MSB + 7 bits
ENCODE_BY_LITTEL_ENDIAN = LITTLE_ENDIAN, // 1234
ENCODE_BY_LITTLE_ENDIAN = LITTLE_ENDIAN, // 1234
ENCODE_BY_BIG_ENDIAN = BIG_ENDIAN, // 4321
Comment on lines 499 to 501
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes the public enum constant ENCODE_BY_LITTEL_ENDIAN. The PR description mentions adding a backward-compatible alias, but there is no #define (and no enum alias) in this header, so this is currently a breaking API change for downstream users. Consider adding a compatibility alias (e.g., keep ENCODE_BY_LITTEL_ENDIAN as an additional enum value equal to ENCODE_BY_LITTLE_ENDIAN, or add a #define mapping) and optionally mark it deprecated in a comment.

Copilot uses AI. Check for mistakes.
ENCODE_BY_ASN1 = 80, // asn1 decode int
} unpack_coding_e;
Expand Down
Loading