Fix typo: ENCODE_BY_LITTEL_ENDIAN → ENCODE_BY_LITTLE_ENDIAN#825
Fix typo: ENCODE_BY_LITTEL_ENDIAN → ENCODE_BY_LITTLE_ENDIAN#825
Conversation
Agent-Logs-Url: https://github.com/ithewei/libhv/sessions/8e4ecff3-c8d8-43af-b29d-336c92e28c28 Co-authored-by: ithewei <26049660+ithewei@users.noreply.github.com>
Removed backward compatibility definition for ENCODE_BY_LITTEL_ENDIAN.
There was a problem hiding this comment.
Pull request overview
This PR corrects a typo in the public unpack_coding_e enum within event/hloop.h by renaming the little-endian encoding constant to the correctly spelled identifier.
Changes:
- Renamed
ENCODE_BY_LITTEL_ENDIANtoENCODE_BY_LITTLE_ENDIANinunpack_coding_e.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ENCODE_BY_VARINT = 17, // 1 MSB + 7 bits | ||
| ENCODE_BY_LITTEL_ENDIAN = LITTLE_ENDIAN, // 1234 | ||
| ENCODE_BY_LITTLE_ENDIAN = LITTLE_ENDIAN, // 1234 | ||
| ENCODE_BY_BIG_ENDIAN = BIG_ENDIAN, // 4321 |
There was a problem hiding this comment.
This change removes the public enum constant ENCODE_BY_LITTEL_ENDIAN. The PR description mentions adding a backward-compatible alias, but there is no #define (and no enum alias) in this header, so this is currently a breaking API change for downstream users. Consider adding a compatibility alias (e.g., keep ENCODE_BY_LITTEL_ENDIAN as an additional enum value equal to ENCODE_BY_LITTLE_ENDIAN, or add a #define mapping) and optionally mark it deprecated in a comment.
Typo in
unpack_coding_eenum inevent/hloop.h:LITTEL→LITTLE.ENCODE_BY_LITTEL_ENDIANtoENCODE_BY_LITTLE_ENDIAN#definemapping the old name to the new one to avoid breaking existing consumers