Skip to content

Address IndexedDB deletion review comments #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
issackjohn wants to merge 3 commits into from
+16 −16
Closed

Address IndexedDB deletion review comments #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65582ba
Address IndexedDB deletion review comments
issackjohn May 6, 2026
49264d5
Reset IndexedDB completion counters on DB init
issackjohn May 6, 2026
0be02ba
Narrow IndexedDB review fix scope
issackjohn May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions experimental/javascript-wc-indexeddb/dist/src/workload-test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ const deletePromise = new Promise((resolve) => {
window.addEventListener(promisesEventsNames.delete, () => resolve());
});

function waitForPreviousPageLoaded() {
return new Promise((resolve) => {
window.addEventListener("previous-page-loaded", resolve, { once: true });
});
}

const suites = {
default: new BenchmarkSuite("indexeddb", [
new BenchmarkStep(`Adding${numberOfItemsToAdd}Items`, async () => {
Expand Down Expand Up @@ -65,14 +71,7 @@ const suites = {
new BenchmarkStep("DeletingAllItems", async () => {
const numberOfItemsPerIteration = 10;
const numberOfIterations = 10;
function iterationFinishedListener() {
iterationFinishedListener.promiseResolve();
}
window.addEventListener("previous-page-loaded", iterationFinishedListener);
for (let j = 0; j < numberOfIterations; j++) {
const iterationFinishedPromise = new Promise((resolve) => {
iterationFinishedListener.promiseResolve = resolve;
});
const todoList = document.querySelector("todo-app").shadowRoot.querySelector("todo-list");
const items = todoList.shadowRoot.querySelectorAll("todo-item");
for (let i = numberOfItemsPerIteration - 1; i >= 0; i--) {
Expand All @@ -81,8 +80,9 @@ const suites = {
}
if (j < 9) {
const previousPageButton = document.querySelector("todo-app").shadowRoot.querySelector("todo-bottombar").shadowRoot.querySelector(".previous-page-button");
const previousPageLoadedPromise = waitForPreviousPageLoaded();
previousPageButton.click();
await iterationFinishedPromise;
await previousPageLoadedPromise;
}
}
}),
Expand Down
16 changes: 8 additions & 8 deletions experimental/javascript-wc-indexeddb/src/workload-test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ const deletePromise = new Promise((resolve) => {
window.addEventListener(promisesEventsNames.delete, () => resolve());
});

function waitForPreviousPageLoaded() {
return new Promise((resolve) => {
window.addEventListener("previous-page-loaded", resolve, { once: true });
});
}

const suites = {
default: new BenchmarkSuite("indexeddb", [
new BenchmarkStep(`Adding${numberOfItemsToAdd}Items`, async () => {
Expand Down Expand Up @@ -65,14 +71,7 @@ const suites = {
new BenchmarkStep("DeletingAllItems", async () => {
const numberOfItemsPerIteration = 10;
const numberOfIterations = 10;
function iterationFinishedListener() {
iterationFinishedListener.promiseResolve();
}
window.addEventListener("previous-page-loaded", iterationFinishedListener);
for (let j = 0; j < numberOfIterations; j++) {
const iterationFinishedPromise = new Promise((resolve) => {
iterationFinishedListener.promiseResolve = resolve;
});
const todoList = document.querySelector("todo-app").shadowRoot.querySelector("todo-list");
const items = todoList.shadowRoot.querySelectorAll("todo-item");
for (let i = numberOfItemsPerIteration - 1; i >= 0; i--) {
Expand All @@ -81,8 +80,9 @@ const suites = {
}
if (j < 9) {
const previousPageButton = document.querySelector("todo-app").shadowRoot.querySelector("todo-bottombar").shadowRoot.querySelector(".previous-page-button");
const previousPageLoadedPromise = waitForPreviousPageLoaded();
previousPageButton.click();
await iterationFinishedPromise;
await previousPageLoadedPromise;
}
}
}),
Expand Down