Address IndexedDB deletion review comments#47
Draft
issackjohn wants to merge 2 commits intoissackjohn-WCIndexeddbfrom
Draft
Address IndexedDB deletion review comments#47issackjohn wants to merge 2 commits intoissackjohn-WCIndexeddbfrom
issackjohn wants to merge 2 commits intoissackjohn-WCIndexeddbfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the IndexedDB TodoMVC workload to make delete/page-navigation sequencing deterministic by waiting for IndexedDB delete completion per page before navigating to the previous page, addressing review feedback from PR WebKit#531.
Changes:
- Add a per-item deletion completion event (
db-delete-item-completed) and use it to await each delete batch before paging back. - Refactor deletion benchmark synchronization to avoid storing resolver state on an event listener and instead use per-iteration promises with one-shot listeners where applicable.
- Update documentation to describe the ordered delete/read behavior, and mirror changes into
dist/.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| experimental/javascript-wc-indexeddb/src/workload-test.mjs | Introduces per-iteration wait helpers and waits for delete batch completion before triggering/loading the previous page. |
| experimental/javascript-wc-indexeddb/src/storage/base-storage-manager.js | Dispatches a new per-item deletion progress event used by the benchmark to synchronize delete batches. |
| experimental/javascript-wc-indexeddb/README.md | Documents the ordered delete-then-read behavior during page navigation in the delete step. |
| experimental/javascript-wc-indexeddb/dist/src/workload-test.mjs | Built output mirroring the updated benchmark synchronization logic. |
| experimental/javascript-wc-indexeddb/dist/src/storage/base-storage-manager.js | Built output mirroring the new per-item deletion progress event dispatch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses recent PR 531 review feedback by removing resolver state from the deletion listener and synchronizing each delete batch with IndexedDB completion before loading the previous page. Updates source, dist, and README.