-
Notifications
You must be signed in to change notification settings - Fork 3k
[Newton] Full Rigid Body Support #4385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/newton
Are you sure you want to change the base?
[Newton] Full Rigid Body Support #4385
Conversation
Greptile Summary
Important Files Changed
Confidence score: 2/5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18 files reviewed, 30 comments
source/isaaclab_newton/test/assets/rigid_object/benchmark_rigid_object_data.py
Show resolved
Hide resolved
source/isaaclab_newton/test/assets/rigid_object/benchmark_rigid_object_data.py
Show resolved
Hide resolved
source/isaaclab_newton/test/assets/articulation/benchmark_articulation.py
Show resolved
Hide resolved
source/isaaclab_newton/isaaclab_newton/assets/rigid_object/rigid_object_data.py
Show resolved
Hide resolved
source/isaaclab_newton/isaaclab_newton/assets/rigid_object/rigid_object.py
Show resolved
Hide resolved
source/isaaclab_newton/isaaclab_newton/assets/rigid_object/rigid_object.py
Show resolved
Hide resolved
source/isaaclab_newton/isaaclab_newton/assets/rigid_object/rigid_object.py
Show resolved
Hide resolved
… at least). There are still some errors some will be patched by latest newton.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (8)
-
source/isaaclab/isaaclab/assets/rigid_object/rigid_object.py, line 20-30 (link)syntax: Multiple references to 'articulation' instead of 'rigid object' in docstrings and comments create confusion about the class's actual purpose
-
source/isaaclab_newton/test/assets/rigid_object/test_rigid_object.py, line 6-19 (link)syntax: Docstring incorrectly refers to 'Articulation class' throughout instead of 'RigidObject class'
-
source/isaaclab/isaaclab/sim/_impl/newton_manager.py, line 124-131 (link)style: Debug print statements should be removed before production release
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
source/isaaclab/isaaclab/sim/_impl/newton_manager.py, line 148-149 (link)style: Debug print statement should be removed before production release
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
source/isaaclab/isaaclab/sim/_impl/newton_manager.py, line 193 (link)style: Debug print statement should be removed before production release
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
source/isaaclab_newton/test/assets/rigid_object/test_rigid_object_data.py, line 6 (link)syntax: Docstring incorrectly refers to 'ArticulationData' instead of 'RigidObjectData'
-
source/isaaclab_newton/test/assets/rigid_object/test_rigid_object_data.py, line 245 (link)syntax: Variable named 'articulation_data' should be 'rigid_object_data' for consistency
-
source/isaaclab_newton/test/assets/rigid_object/test_rigid_object_data.py, line 254-268 (link)syntax: Multiple references to 'articulation_data' should be 'rigid_object_data'
18 files reviewed, 16 comments
source/isaaclab_newton/test/assets/rigid_object/benchmark_rigid_object_data.py
Show resolved
Hide resolved
source/isaaclab_newton/test/assets/rigid_object/benchmark_rigid_object_data.py
Show resolved
Hide resolved
| # | ||
| # SPDX-License-Identifier: BSD-3-Clause | ||
|
|
||
| """Mock interfaces for testing and benchmarking ArticulationData class.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: Docstring refers to 'ArticulationData class' but this file is for rigid object testing
| """Mock interfaces for testing and benchmarking ArticulationData class.""" | |
| """Mock interfaces for testing and benchmarking RigidObjectData class.""" |
source/isaaclab_newton/isaaclab_newton/assets/rigid_object/rigid_object.py
Show resolved
Hide resolved
source/isaaclab_newton/test/assets/rigid_object/test_rigid_object_data.py
Show resolved
Hide resolved
source/isaaclab_newton/test/assets/rigid_object/test_rigid_object_data.py
Show resolved
Hide resolved
source/isaaclab_newton/test/assets/rigid_object/test_rigid_object_data.py
Show resolved
Hide resolved
fdf4241 to
8afadee
Compare
|
Skipped: This PR changes more files than the configured file change limit: ( |
Description
Adds back support for Rigid bodies.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there