Support multi-env & enable_cameras in multi-task eval #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmillane
approved these changes
Jan 28, 2026
Collaborator
alexmillane
left a comment
alexmillane
left a comment
There was a problem hiding this comment.
Looks great! Thank you for adding this!
Comment on lines
+57
to
+59
| # will not override the enable_cameras flag if it is already set from cli | ||
| if not hasattr(args_cli, "enable_cameras") or not args_cli.enable_cameras: | ||
| args_cli.enable_cameras = True |
Collaborator
There was a problem hiding this comment.
This comment confused me a bit. If args.enable_cameras doesn't exist or is Flase we set it, effective overriding the command line. If it's already True we don't set it to True again (which is kind of a no-op anyway). I think we can just remove this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Evaluation jobs may have different num of envs. Some may require camera sensors and some may not.
Eval_runnerneeds to handle those configurations with persistent app setup.Detailed description
enable_cameraif any job requires cameras before Sim App starts