Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions core/src/tests/web-plugin.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -181,4 +181,30 @@ describe('Web Plugin', () => {

expect(handlerFunction).not.toHaveBeenCalled();
});

it('Should not remove a listener if it is not found', async () => {
const lf1 = (event: any) => {
console.log(event);
};
const lf2 = (event: any) => {
console.log(event);
};
const lf3 = (event: any) => {
console.log(event);
};

await plugin.addListener('test', lf1);
await plugin.addListener('test', lf2);

const listenersBefore = plugin.getListeners()['test'];
expect(listenersBefore.length).toEqual(2);

// Try to remove a listener that was never added
await (plugin as any).removeListener('test', lf3);

const listenersAfter = plugin.getListeners()['test'];
expect(listenersAfter.length).toEqual(2);
expect(listenersAfter[0]).toBe(lf1);
expect(listenersAfter[1]).toBe(lf2);
});
});
4 changes: 3 additions & 1 deletion core/src/web-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,9 @@ export class WebPlugin implements Plugin {
}

const index = listeners.indexOf(listenerFunc);
this.listeners[eventName].splice(index, 1);
if (index !== -1) {
this.listeners[eventName].splice(index, 1);
}

// If there are no more listeners for this type of event,
// remove the window listener
Expand Down