-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(core): prevent removeListener from removing wrong listener #8271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maniktyagi04
wants to merge
1
commit into
ionic-team:main
Choose a base branch
from
maniktyagi04:fix/web-plugin-removelistener-bug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(core): prevent removeListener from removing wrong listener #8271
maniktyagi04
wants to merge
1
commit into
ionic-team:main
from
maniktyagi04:fix/web-plugin-removelistener-bug
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When removeListener is called with a listener that doesn't exist, indexOf returns -1, and splice(-1, 1) removes the last element. This fix adds a check to only splice if the listener is found. Fixes: Incorrect listener removal when listener not found
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 4, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 5, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 6, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 7, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 8, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 9, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 10, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 11, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 12, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 13, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 14, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 15, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 16, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 17, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 18, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 19, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 20, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 21, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 22, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 23, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 24, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 25, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 26, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8269
When
removeListeneris called with a listener that doesn't exist,indexOfreturns-1, andsplice(-1, 1)removes the last element in the array. This PR adds a check to only splice if the listener is found.Changes
removeListenermethodTesting
Impact
Before
After