[SYCL][NFC] Clean up remaining references to PI#21355
Open
sergey-semenov wants to merge 2 commits intointel:syclfrom
Open
[SYCL][NFC] Clean up remaining references to PI#21355sergey-semenov wants to merge 2 commits intointel:syclfrom
sergey-semenov wants to merge 2 commits intointel:syclfrom
Conversation
Contributor
Author
|
@cperkinsintel @intel/llvm-reviewers-runtime Could you please have a quick look? |
uditagarwal97
approved these changes
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Cleans up remaining references to the deprecated “PI” naming in SYCL runtime and unit tests by consistently switching terminology to “UR”, aligning the codebase with the Unified Runtime API naming.
Changes:
- Renamed
producesPiEvent()toproducesUrEvent()across scheduler command types and updated all call sites. - Updated unit test names and various comments/identifiers from
Pi*toUr*. - Renamed macro parameters (
PiCode→UrCode) and a few local variables to remove lingering PI terminology.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sycl/unittests/scheduler/Commands.cpp | Updates a remaining PI reference in a comment to UR terminology. |
| sycl/unittests/queue/InteropRetain.cpp | Renames the gtest suite from PiInteropTest to UrInteropTest. |
| sycl/unittests/Extensions/OneAPIProd.cpp | Renames the test name from PiQueueFlush to UrQueueFlush. |
| sycl/source/platform.cpp | Renames macro parameter to remove PI naming. |
| sycl/source/kernel.cpp | Renames macro parameter to remove PI naming (two macro sites). |
| sycl/source/handler.cpp | Renames a local PiFormat variable to UrFormat for ur_image_format_t. |
| sycl/source/event.cpp | Renames macro parameter to remove PI naming (two macro sites). |
| sycl/source/device.cpp | Renames macro parameters to remove PI naming (including specialized macro). |
| sycl/source/detail/ur_info_code.hpp | Renames macro parameter forwarding (PiCode → UrCode). |
| sycl/source/detail/scheduler/commands.hpp | Renames the virtual API to producesUrEvent() and updates overrides. |
| sycl/source/detail/scheduler/commands.cpp | Updates implementation and logic to use producesUrEvent() and renames a related local variable. |
| sycl/source/detail/queue_impl.hpp | Removes a commented-out PI properties snippet. |
| sycl/source/detail/queue_impl.cpp | Updates an inline comment label from PiEvent to UrEvent. |
| sycl/source/detail/program_manager/program_manager.cpp | Updates a commented-out PI type reference to UR terminology. |
| sycl/source/detail/memory_manager.cpp | Updates comments referring to OwnedPiEvent → OwnedUrEvent. |
| sycl/source/detail/helpers.cpp | Updates scheduler/event handling logic to call producesUrEvent(). |
| sycl/source/context.cpp | Renames macro parameter to remove PI naming. |
| sycl/include/sycl/detail/info_desc_helpers.hpp | Renames macro parameters to remove PI naming. |
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Contributor
|
@sergey-semenov Maybe the CMake variable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.