Skip to content

[SYCL][NFC] Clean up remaining references to PI#21355

Open
sergey-semenov wants to merge 2 commits intointel:syclfrom
sergey-semenov:removepirefs
Open

[SYCL][NFC] Clean up remaining references to PI#21355
sergey-semenov wants to merge 2 commits intointel:syclfrom
sergey-semenov:removepirefs

Conversation

@sergey-semenov
Copy link
Contributor

No description provided.

@sergey-semenov
Copy link
Contributor Author

@cperkinsintel @intel/llvm-reviewers-runtime Could you please have a quick look?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Cleans up remaining references to the deprecated “PI” naming in SYCL runtime and unit tests by consistently switching terminology to “UR”, aligning the codebase with the Unified Runtime API naming.

Changes:

  • Renamed producesPiEvent() to producesUrEvent() across scheduler command types and updated all call sites.
  • Updated unit test names and various comments/identifiers from Pi* to Ur*.
  • Renamed macro parameters (PiCodeUrCode) and a few local variables to remove lingering PI terminology.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sycl/unittests/scheduler/Commands.cpp Updates a remaining PI reference in a comment to UR terminology.
sycl/unittests/queue/InteropRetain.cpp Renames the gtest suite from PiInteropTest to UrInteropTest.
sycl/unittests/Extensions/OneAPIProd.cpp Renames the test name from PiQueueFlush to UrQueueFlush.
sycl/source/platform.cpp Renames macro parameter to remove PI naming.
sycl/source/kernel.cpp Renames macro parameter to remove PI naming (two macro sites).
sycl/source/handler.cpp Renames a local PiFormat variable to UrFormat for ur_image_format_t.
sycl/source/event.cpp Renames macro parameter to remove PI naming (two macro sites).
sycl/source/device.cpp Renames macro parameters to remove PI naming (including specialized macro).
sycl/source/detail/ur_info_code.hpp Renames macro parameter forwarding (PiCodeUrCode).
sycl/source/detail/scheduler/commands.hpp Renames the virtual API to producesUrEvent() and updates overrides.
sycl/source/detail/scheduler/commands.cpp Updates implementation and logic to use producesUrEvent() and renames a related local variable.
sycl/source/detail/queue_impl.hpp Removes a commented-out PI properties snippet.
sycl/source/detail/queue_impl.cpp Updates an inline comment label from PiEvent to UrEvent.
sycl/source/detail/program_manager/program_manager.cpp Updates a commented-out PI type reference to UR terminology.
sycl/source/detail/memory_manager.cpp Updates comments referring to OwnedPiEventOwnedUrEvent.
sycl/source/detail/helpers.cpp Updates scheduler/event handling logic to call producesUrEvent().
sycl/source/context.cpp Renames macro parameter to remove PI naming.
sycl/include/sycl/detail/info_desc_helpers.hpp Renames macro parameters to remove PI naming.

@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@sarnex
Copy link
Contributor

sarnex commented Feb 26, 2026

@sergey-semenov Maybe the CMake variable SYCL_BUILD_PI_HIP_PLATFORM too?

@sergey-semenov sergey-semenov requested a review from a team as a code owner February 26, 2026 18:28
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants