refactor: update regression test dependencies#2537
Conversation
|
There was a problem hiding this comment.
I ran the lint command locally. It is a small project but the running time was very long, almost a minute. It found a surprisingly high number of issues:
✖ 370340 problems (286751 errors, 83589 warnings)
271514 errors and 0 warnings potentially fixable with the --fix option.
It goes into every folder, even into build artifacts and next js runtime built files, I would ignore those, please look into it. Cypress command was ok.
matyasf
force-pushed
the
update_regression_deps
branch
2 times, most recently
from
518e029 to
705b60e
Compare
|
|
||
| export default function placeholderImage(width = 512, height = 512) { | ||
| // We need to base64 encode this because otherwise FF will add extra escape chars | ||
| // eslint-disable-next-line no-undef |
There was a problem hiding this comment.
There were some random files that havent been linted for a while and our linter config changes, so they were showing errors. This is fixed now
I've fixed this, the |
Also use ESLint from the root package
matyasf
force-pushed
the
update_regression_deps
branch
from
705b60e to
14e910e
Compare
Visual regression report✅ No changes.
Baselines come from the |
joyenjoyer
left a comment
joyenjoyer
left a comment
There was a problem hiding this comment.
looks ok, eslint runs well
2 participants
Also use ESLint from the root package.
To check: