Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ const finalConfig = tseslint.config(
"/regression-test/**",
"/coverage/**",
"**/stylelint.config.js",
"**/babel.config.js"
"**/babel.config.js",
"**/.next/**",
"**/next-env.d.ts"
]
},
eslint.configs.recommended,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import IconSVG from './placeholder.svg'

export default function placeholderImage(width = 512, height = 512) {
// We need to base64 encode this because otherwise FF will add extra escape chars
// eslint-disable-next-line no-undef
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some random files that havent been linted for a while and our linter config changes, so they were showing errors. This is fixed now

const dataUri = Buffer.from(
IconSVG.replace(/{{w}}/g, width).replace(/{{h}}/g, height).trim()
).toString('base64')
Expand Down
3 changes: 2 additions & 1 deletion packages/command-utils/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import { sync, spawn } from 'cross-spawn'
const require = createRequire(import.meta.url)

function info(...args) {
console.info(chalk.blue(...args)) // eslint-disable-line no-console
console.info(chalk.blue(...args))
}

function warn(...args) {
Expand Down Expand Up @@ -163,6 +163,7 @@ function resolveBin(
let pathFromWhich
try {
pathFromWhich = fs.realpathSync(which.sync(executable))
// eslint-disable-next-line no-unused-vars
} catch (_error) {
// ignore _error
}
Expand Down
1 change: 0 additions & 1 deletion packages/ui-alerts/src/Alert/v1/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,6 @@ class Alert extends Component<AlertProps, AlertState> {

renderAlert() {
// prevent onDismiss from being passed to the View component
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const {
margin,
styles,
Expand Down
1 change: 0 additions & 1 deletion packages/ui-alerts/src/Alert/v2/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ class Alert extends Component<AlertProps, AlertState> {

renderAlert() {
// prevent onDismiss from being passed to the View component
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const {
margin,
styles,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import React from 'react'
import type { DeterministicIdProviderValue } from './DeterministicIdContextProvider'

declare global {
// eslint-disable-next-line no-var
var __INSTUI_GLOBAL_INSTANCE_COUNTER__: Map<string, number>
}
const instUIInstanceCounter = '__INSTUI_GLOBAL_INSTANCE_COUNTER__'
Expand Down
1 change: 0 additions & 1 deletion packages/ui-scripts/lib/icons/build-icons.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ export default {
JSON.stringify(legacyIconsData, null, 2),
'utf8'
)
// eslint-disable-next-line no-console
console.log(
`Generated ${legacyOutputPath} (${legacyIconsData.length} icons)`
)
Expand Down
1 change: 0 additions & 1 deletion regression-test/.eslintignore

This file was deleted.

3 changes: 0 additions & 3 deletions regression-test/.eslintrc.json

This file was deleted.

28 changes: 28 additions & 0 deletions regression-test/eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/*
* The MIT License (MIT)
*
* Copyright (c) 2015 - present Instructure, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/

// eslint-disable-next-line @instructure/no-relative-imports
import cfg from '../eslint.config.mjs'

export default cfg
Loading
Loading