Follow-ups from the coding session on 2025-03-11#49
Merged
ehrenfeu merged 68 commits intoimcf:develfrom Mar 26, 2025
Merged
Conversation
Add one to apply a filter, to do rolling ball background subtraction and thresholding
This method could be improved to be used in the stitching script
ehrenfeu
requested changes
Mar 18, 2025
ehrenfeu
reviewed
Mar 25, 2025
Member
ehrenfeu
requested changes
Mar 25, 2025
Member
There was a problem hiding this comment.
Remaining open requests (plus the one attached below to this very comment):
- docstring for
calculate_mean_and_stdv(): #49 (comment) - move
pad_number()tostrtools: #49 (comment) - rename
apply_background_subtractiontorollingball_background_subtractionorapply_rollingball_bg_subtraction: #49 (comment)
69d9851 to
f0a1c9c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #49 +/- ##
==========================================
- Coverage 28.19% 25.06% -3.14%
==========================================
Files 24 25 +1
Lines 1426 1656 +230
==========================================
+ Hits 402 415 +13
- Misses 1024 1241 +217 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@lguerard how about we merge this PR now and address the remaining tasks in separate issues later on?
|
This was referenced Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.