Add imagej.projections.project_stack()#40
Conversation
|
Waiting for imcf/imcf-fiji-mocks#3 to be completed & 🔀 merged, in order for the tests 🧪 to pass. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #40 +/- ##
========================================
Coverage ? 28.33%
========================================
Files ? 24
Lines ? 1394
Branches ? 0
========================================
Hits ? 395
Misses ? 999
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ehrenfeu
left a comment
ehrenfeu
left a comment
There was a problem hiding this comment.
Please see the in-line comments / requests.
src/imcflibs/imagej/projections.py
Outdated
|
|
||
|
|
||
| def project_stack(imp, projected_dimension, projection_type, ops, ds, cs): | ||
| """ |
There was a problem hiding this comment.
Please have the function summary on the same line as the opening quotes """ and make it less than 88 characters in total.
Try to use minimalist phrasing, this is really meant to be a one-liner that conveys the idea of the function, for example this one could be:
def project_stack(imp, projected_dimension, projection_type, ops, ds, cs):
"""Project along a defined axis using the given projection type.
[bla...]
"""|
|
||
| Parameters | ||
| ---------- | ||
| imp : ImagePlus |
There was a problem hiding this comment.
Make sure docstrings do not exceed the 88 chars line length, you may want to consider the Rewrap Revived extension for VS Code for doing this.
ehrenfeu
left a comment
ehrenfeu
left a comment
There was a problem hiding this comment.
❤️ Thanks a lot!
Unlike what I said when leaving the office a while ago, there's nothing else to fix (I was confusing other linting issues fully unrelated to this PR... 🤦🏼♂️).
Ready to be merged! 🔀 🚀
|
Hooray \o/ :D
|
|
@CellKai the merge was happening in a slightly unexpected way (GitHub only offered a rebase or squash), so no idea what the status in your fork of the repo would be now (after my rebase-merge). In case your repo still contains the branch that was used to start this PR, you may delete the branch now. |
2 participants
No description provided.