fix(ui): remove route-triggered effect auto-apply#61
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughEffectsPage removes 29 lines of URL-parameter-based routing logic. The Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aaaa47b to
ee3df16
Compare
Motivation
/effects/:id) from causing an implicit first-party POST mutation (/api/v1/effects/{id}/apply) by removing client-side logic that auto-applied effects when that route parameter was present.Description
use_params_mapusage and the route-parameter wiring fromcrates/hypercolor-ui/src/pages/effects.rsand delete the reactiveEffectthat automatically calledfx.apply_effect(...)on route navigation so effect application requires an explicit in-app action.Testing
cargo check --workspacein this environment but the full compilation did not complete within the interactive session, so no final pass/fail was captured.Codex Task
Summary by CodeRabbit