Skip to content

fix(ui): remove route-triggered effect auto-apply #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperb1iss merged 1 commit into from
May 19, 2026
Merged

fix(ui): remove route-triggered effect auto-apply #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions crates/hypercolor-ui/src/pages/effects.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

use leptos::prelude::*;
use leptos_icons::Icon;
use leptos_router::hooks::use_params_map;
use leptos_use::use_debounce_fn;

use crate::api;
Expand Down Expand Up @@ -53,7 +52,6 @@ const CATEGORY_CHIPS: &[(&str, &str)] = &[
pub fn EffectsPage() -> impl IntoView {
let ws = expect_context::<WsContext>();
let fx = expect_context::<EffectsContext>();
let route_params = use_params_map();

Effect::new(move |_| {
ws.set_preview_cap.set(EFFECTS_PREVIEW_FPS_CAP);
Expand Down Expand Up @@ -211,33 +209,6 @@ pub fn EffectsPage() -> impl IntoView {
.map(|entry| entry.effect.clone())
})
});
let routed_effect_id = Memo::new(move |_| {
let route_effect_id = route_params.with(|params| params.get("id"))?;
fx.effects_index.with(|effects| {
effects
.iter()
.find(|entry| entry.effect.id == route_effect_id)
.and_then(|entry| {
(entry.effect.runnable
&& !entry.effect.category.eq_ignore_ascii_case("display"))
.then(|| entry.effect.id.clone())
})
})
});
Effect::new(move |previous_route_effect_id: Option<Option<String>>| {
let current_route_effect_id = routed_effect_id.get();
if previous_route_effect_id.as_ref() == Some(&current_route_effect_id) {
return current_route_effect_id;
}

if let Some(effect_id) = current_route_effect_id.as_ref()
&& fx.active_effect_id.get_untracked().as_deref() != Some(effect_id.as_str())
{
fx.apply_effect(effect_id.clone());
}

current_route_effect_id
});
let show_calibration_guide = Memo::new(move |_| {
active_effect_summary.get().is_some_and(|effect| {
effect.name.eq_ignore_ascii_case("Calibration")
Expand Down
Loading