Skip to content

Remove old mkVersion#11630

Open
zlonast wants to merge 5 commits intohaskell:masterfrom
zlonast:zlonast/old-mkVersion
Open

Remove old mkVersion#11630
zlonast wants to merge 5 commits intohaskell:masterfrom
zlonast:zlonast/old-mkVersion

Conversation

@zlonast
Copy link
Collaborator

@zlonast zlonast commented Mar 17, 2026

We don't have any testing for such old versions of ghc. Since this code isn't used, I assume it doesn't work, but it's difficult to confirm otherwise.

We just dropped everything below 8.0.0


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@zlonast
Copy link
Collaborator Author

zlonast commented Mar 17, 2026

Should we drop compilers below 8.6? Or 8.8?

@zlonast zlonast force-pushed the zlonast/old-mkVersion branch 3 times, most recently from 1cd54e4 to 27e6671 Compare March 17, 2026 19:15
@ffaf1
Copy link
Collaborator

ffaf1 commented Mar 17, 2026

This does modify behaviour, does it not?

@zlonast zlonast force-pushed the zlonast/old-mkVersion branch from 27e6671 to 9f262e4 Compare March 17, 2026 19:48
@zlonast zlonast force-pushed the zlonast/old-mkVersion branch from 9f262e4 to 2547133 Compare March 17, 2026 20:17
@zlonast
Copy link
Collaborator Author

zlonast commented Mar 18, 2026

@ffaf1 It seems to me that if I can't compile the code with an old compiler, then this doesn't count as a change in behavior.

@ffaf1
Copy link
Collaborator

ffaf1 commented Mar 18, 2026

@ffaf1 It seems to me that if I can't compile the code with an old compiler, then this doesn't count as a change in behavior.

Makes sense!

@zlonast zlonast mentioned this pull request Mar 21, 2026
6 tasks
@zlonast zlonast requested review from ffaf1 and ulysses4ever March 21, 2026 19:33
, Z.zVersionDigits = show $ versionNumbers $ packageVersion pkg_descr
, Z.zSupportsCpp = supports_cpp
, Z.zSupportsNoRebindableSyntax = supports_rebindable_syntax
, Z.zSupportsCpp = True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same problem, is it not?
Will zSuppoerCpp ever be False?
Or is it different?

build-depends:
, aeson ^>=2.2.3.0
, base >=4.13 && <4.21
, base >=4.13 && <4.22
Copy link
Collaborator

@ffaf1 ffaf1 Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like your comment on this one.
Why did you bump the bound?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps because base < 4.21 is outdated by now?..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is related to removing stale mkVersion because…?
I do not see separate commits, so I am sure there is a rationale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants