Conversation
|
Should we drop compilers below 8.6? Or 8.8? |
1cd54e4 to
27e6671
Compare
|
This does modify behaviour, does it not? |
27e6671 to
9f262e4
Compare
9f262e4 to
2547133
Compare
|
@ffaf1 It seems to me that if I can't compile the code with an old compiler, then this doesn't count as a change in behavior. |
Makes sense! |
| , Z.zVersionDigits = show $ versionNumbers $ packageVersion pkg_descr | ||
| , Z.zSupportsCpp = supports_cpp | ||
| , Z.zSupportsNoRebindableSyntax = supports_rebindable_syntax | ||
| , Z.zSupportsCpp = True |
There was a problem hiding this comment.
This is the same problem, is it not?
Will zSuppoerCpp ever be False?
Or is it different?
| build-depends: | ||
| , aeson ^>=2.2.3.0 | ||
| , base >=4.13 && <4.21 | ||
| , base >=4.13 && <4.22 |
There was a problem hiding this comment.
I would like your comment on this one.
Why did you bump the bound?
There was a problem hiding this comment.
Perhaps because base < 4.21 is outdated by now?..
There was a problem hiding this comment.
And this is related to removing stale mkVersion because…?
I do not see separate commits, so I am sure there is a rationale.
We don't have any testing for such old versions of ghc. Since this code isn't used, I assume it doesn't work, but it's difficult to confirm otherwise.
We just dropped everything below 8.0.0
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.