Conversation
0ec2a49 to
4accda8
Compare
4accda8 to
326631c
Compare
| threadDelay 1000 | ||
| removeFile fp | ||
| -- Else we give up. | ||
| | otherwise -> throwIO e |
There was a problem hiding this comment.
In Haskell, we have very poor support for Windows operating system errors. The libraries provided by the compiler don't have a comprehensive manual catch for these errors for Windows. Essentially, we only catch errors on Linux and Mac (so-called errno). I think this will also silently crash, like renameFileWithRetry.
There was a problem hiding this comment.
The main idea here is having a shared helper to handle isDoesNotExistError, the rest of error handling is bolt-on. In my manual testing it works reasonably ok-ish, although certainly not bulletproof.
There was a problem hiding this comment.
Point of order: this has to be resolved before the pr can be merged.
zlonast
left a comment
There was a problem hiding this comment.
Personally, I like this pull request, just like renameFileWithRetry. But it doesn't prevent the silent death of the build on Windows.
|
Anyone else up for review please? |
| threadDelay 1000 | ||
| removeFile fp | ||
| -- Else we give up. | ||
| | otherwise -> throwIO e |
There was a problem hiding this comment.
Point of order: this has to be resolved before the pr can be merged.
Closes #11606.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.