Skip to content

fix: wait for volume to become available before cleanup deletion #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Autherain wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

fix: wait for volume to become available before cleanup deletion #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions builder/openstack/step_create_volume.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,17 @@ func (s *StepCreateVolume) Cleanup(state multistep.StateBag) {
return
}

ui.Say(fmt.Sprintf("Deleting volume: %s ...", s.volumeID))
// Wait for the volume to become available before deleting.
// After image creation from a volume, Cinder may still be detaching it
// (status "uploading"). Deleting in that state returns a 400 error.
ui.Say(fmt.Sprintf("Waiting for volume %s to become available...", s.volumeID))
if err := WaitForVolume(blockStorageClient, s.volumeID); err != nil {
ui.Error(fmt.Sprintf(
"Error waiting for volume %s to become available: %s. Attempting deletion anyway.",
s.volumeID, err))
}

// Delete the volume in any status if exists.
ui.Say(fmt.Sprintf("Deleting volume: %s ...", s.volumeID))
err = volumes.Delete(blockStorageClient, s.volumeID, volumes.DeleteOpts{}).ExtractErr()
if err != nil {
ui.Error(fmt.Sprintf(
Expand Down