fix: wait for volume to become available before cleanup deletion#150
Open
Autherain wants to merge 1 commit intohashicorp:mainfrom
Open
fix: wait for volume to become available before cleanup deletion#150Autherain wants to merge 1 commit intohashicorp:mainfrom
Autherain wants to merge 1 commit intohashicorp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123
Problem
When
use_blockstorage_volumeis enabled, theCleanup()method in StepCreateVolume` attempts to delete the volume immediately after the has been created. However, Cinder may still be detaching the (status "uploading"), causing deletion to fail with a 400 error:This leaves orphaned volumes that require manual cleanup.
Fix
Added a call to the existing
WaitForVolume()function before attempting deletion inCleanup(). This polls until the volume reaches "available" or "error" status, which is consistent with howRun()already waits after volume creation.If the wait fails, deletion is still attempted as a best-effort
fallback.
Testing
go build ./...passesgo test ./builder/openstack/...passesgo fmtapplied