Add SPU mips tests (test on HW help needed) #2018
CodeScene PR Check
Quality Gate Failed
Gates Failed
(1 new file with code health below 9.00)
(1 file with Bumpy Road Ahead, Deep, Nested Complexity)
(1 file with Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| New code is healthy | Violations | Code Health Impact | |
|---|---|---|---|
| spu.c | 3 rules | 8.93 | Suppress |
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| spu.c | 2 critical rules | 8.93 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| spu.c | 1 advisory rule | 8.93 | Suppress |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Deep, Nested Complexity spu.c: spu_pcm_analyze
- Complex Method spu.c: spu_dma_sync
- Bumpy Road Ahead spu.c: spu_pcm_analyze
- Bumpy Road Ahead spu.c: spu_compare_golden
Annotations
Check warning on line 192 in src/mips/tests/spu/spu.c
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
spu_dma_sync has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 148 in src/mips/tests/spu/spu.c
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Bumpy Road Ahead
spu_pcm_analyze has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 272 in src/mips/tests/spu/spu.c
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Bumpy Road Ahead
spu_compare_golden has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 148 in src/mips/tests/spu/spu.c
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Deep, Nested Complexity
spu_pcm_analyze has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.