Add SPU mips tests (test on HW help needed)#2018
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I think this generally speaking looks good. We may want to avoid the |
Thanks for the feedback. I removed the For the tests themselves, I reached a point where I am happy with what I wrote so far. I am happy to make further changes where I missed the mark. These tests have been tested only on one console. Before I have the confidence to mark the PR as ready, I'd like help to collect the test run results from other consoles as well. |
I am experimenting a SPU regression suite on a SPCH-5552 to raise the base line to which emulators should adhere to reproduce PS1 sounds accurately.
As of today, tests are non-exhaustive and they occasionally suffer from synchronization issues. These tests aim to purely focus on ADPCM decoding, resampling and the rate ADSR envelopes change the voice volume given a certain set-up. These tests should not depend to accurate CPU cycles, as it would defeat their purpose.
The PR is in draft. I am mostly requesting for feedback. The SPU synchronization is imperfect, and both ADPCM and voice tests might occasionally fail on real hardware. These tests have not been tested on older or newer PS1 revisions, on a PS2 or arcade boards. Tests hang on PCSX Redux due to the SPU Status bit11 flip not being implemented.