add netmod description #743
Conversation
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.gridsuite</groupId> | ||
| <artifactId>gridsuite-network-modification</artifactId> | ||
| <version>${network-modification.version}</version> |
There was a problem hiding this comment.
it is already done in dependenciesManagement
There was a problem hiding this comment.
Indeed. I don't why I added this ! : d888900
src/main/java/org/gridsuite/modification/server/entities/ModificationEntity.java
Show resolved
Hide resolved
|
Could you add a test with a description in any modification ? maybe the same as the one you will do in network modification |
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
| @PutMapping(value = "/network-modifications/{uuid}", produces = MediaType.APPLICATION_JSON_VALUE, params = "description") | ||
| @Operation(summary = "Updates the description of a network modification") | ||
| @ApiResponse(responseCode = "200", description = "The description of the network modification has been successfully updated") | ||
| public ResponseEntity<Void> updateNetworkModificationDescription( |
There was a problem hiding this comment.
Why do you create a new endpoint and you don't reuse the existing update network modification endpoint ?
There was a problem hiding this comment.
I admit I kind of copied the enable/disable but I think it is better to have a specific endpoint because we only have the metadata of the netmod in the front. Not the complete "modificationInfos" and only want to change a specific part of the netmod.
But maybe there is a good way to mutualise. What do you have in mind ?
|
|
||
| assertEquals( | ||
| "TwoWindingsTransformerCreationInfos(super=BranchCreationInfos(super=EquipmentCreationInfos(super=EquipmentModificationInfos(super=ModificationInfos(uuid=null, type=TWO_WINDINGS_TRANSFORMER_CREATION, date=null, stashed=false, messageType=null, messageValues=null, activated=true), equipmentId=id2wt1WithRatioTapChanger2, properties=null), equipmentName=2wtName), r=400.0, x=300.0, voltageLevelId1=v1, voltageLevelId2=v4, busOrBusbarSectionId1=1.1, busOrBusbarSectionId2=1.A, operationalLimitsGroups=null, selectedOperationalLimitsGroup1=null, selectedOperationalLimitsGroup2=null, connectionName1=null, connectionDirection1=TOP, connectionName2=null, connectionDirection2=TOP, connectionPosition1=null, connectionPosition2=null, connected1=true, connected2=true), g=100.0, b=200.0, ratedU1=1000.0, ratedU2=1010.0, ratedS=null, ratioTapChanger=RatioTapChangerCreationInfos(super=TapChangerCreationInfos(lowTapPosition=0, tapPosition=1, regulating=true, targetDeadband=null, terminalRefConnectableId=v1load, terminalRefConnectableType=LOAD, terminalRefConnectableVlId=v1, steps=[TapChangerStepCreationInfos(index=0, rho=1.0, r=39.78473, x=39.784725, g=0.0, b=0.0, alpha=0.0), TapChangerStepCreationInfos(index=0, rho=1.0, r=39.78474, x=39.784726, g=0.0, b=0.0, alpha=0.0), TapChangerStepCreationInfos(index=0, rho=1.0, r=39.78475, x=39.784727, g=0.0, b=0.0, alpha=0.0)], loadTapChangingCapabilities=true), targetV=220.0), phaseTapChanger=null)", | ||
| "TwoWindingsTransformerCreationInfos(super=BranchCreationInfos(super=EquipmentCreationInfos(super=EquipmentModificationInfos(super=ModificationInfos(uuid=null, type=TWO_WINDINGS_TRANSFORMER_CREATION, date=null, stashed=false, messageType=null, messageValues=null, activated=true, description=a dummy description), equipmentId=id2wt1WithRatioTapChanger2, properties=null), equipmentName=2wtName), r=400.0, x=300.0, voltageLevelId1=v1, voltageLevelId2=v4, busOrBusbarSectionId1=1.1, busOrBusbarSectionId2=1.A, operationalLimitsGroups=null, selectedOperationalLimitsGroup1=null, selectedOperationalLimitsGroup2=null, connectionName1=null, connectionDirection1=TOP, connectionName2=null, connectionDirection2=TOP, connectionPosition1=null, connectionPosition2=null, connected1=true, connected2=true), g=100.0, b=200.0, ratedU1=1000.0, ratedU2=1010.0, ratedS=null, ratioTapChanger=RatioTapChangerCreationInfos(super=TapChangerCreationInfos(lowTapPosition=0, tapPosition=1, regulating=true, targetDeadband=null, terminalRefConnectableId=v1load, terminalRefConnectableType=LOAD, terminalRefConnectableVlId=v1, steps=[TapChangerStepCreationInfos(index=0, rho=1.0, r=39.78473, x=39.784725, g=0.0, b=0.0, alpha=0.0), TapChangerStepCreationInfos(index=0, rho=1.0, r=39.78474, x=39.784726, g=0.0, b=0.0, alpha=0.0), TapChangerStepCreationInfos(index=0, rho=1.0, r=39.78475, x=39.784727, g=0.0, b=0.0, alpha=0.0)], loadTapChangingCapabilities=true), targetV=220.0), phaseTapChanger=null)", |
There was a problem hiding this comment.
Do you know why we use string like that instead of JSON ?
There was a problem hiding this comment.
No. I agree that it doesn't look optimal.
I added the same that in the netmod lib : bd58f76 At least it tests the affectation during the creation. The reaffectation should be tested in the controller test. |
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
|
| file: changesets/changelog_20251128T072356Z.xml | ||
| relativeToChangelogFile: true | ||
| - include: | ||
| relativeToChangelogFile: true |
There was a problem hiding this comment.
strange to inverse relativeToChangelogFile and file but ok
EtienneLt
left a comment
EtienneLt
left a comment
There was a problem hiding this comment.
Test Ok code OK for me
PR Summary
Adds a decsription field to all netmods, and the functions/endpoint to change it.