add netmod description #894
Conversation
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
|
|
||
| @Transactional | ||
| public void updateNetworkModificationsDescription(UUID studyUuid, UUID nodeUuid, UUID modificationUuid, String userId, String description) { | ||
| List<UUID> childrenUuids = networkModificationTreeService.getChildrenUuids(nodeUuid); |
There was a problem hiding this comment.
I see this code is used in many others endpoint can we share it in a method ? if it is possible ?
There was a problem hiding this comment.
It’s possible but delicate because these uses are similar but not identical. By example mine doesn't use the groupUuid and, more importantly, doesn't invalidate the nodes.
So I don't think that this is really worth it.
There was a problem hiding this comment.
2 have been merged here : f972646
The third (stashed) has not been merged with the others yet because it is a bit more dangerous. Maybe in a next small technical ticket.
| @PutMapping(value = "/studies/{studyUuid}/nodes/{nodeUuid}/network-modifications", params = "description") | ||
| @Operation(summary = "Update the description of a network modification") | ||
| @ApiResponses(value = {@ApiResponse(responseCode = "200", description = "Update the description of a network modification"), @ApiResponse(responseCode = "404", description = "The study/node is not found")}) | ||
| public ResponseEntity<Void> updateNetworkModificationDescription(@Parameter(description = "Study UUID") @PathVariable("studyUuid") UUID studyUuid, |
There was a problem hiding this comment.
Same as for the other PR. Why do we add a new endpoint?
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
…-netmod-description
| @Parameter(description = "New activated value") @RequestParam(name = "activated", required = true) Boolean activated, | ||
| @RequestHeader(HEADER_USER_ID) String userId) { | ||
| @PutMapping(value = "/studies/{studyUuid}/nodes/{nodeUuid}/network-modifications") | ||
| @Operation(summary = "Updates the metadata of a network modification") |
There was a problem hiding this comment.
| @Operation(summary = "Updates the metadata of a network modification") | |
| @Operation(summary = "Updates metadata of a network modification") |
small thing
src/test/java/org/gridsuite/study/server/NetworkModificationUnitTest.java
Show resolved
Hide resolved
|
PR Summary
intermediary class in order to call the network modification description updater in network-modification-server : gridsuite/network-modification-server#743