Skip to content

[GCI27] System.arraycopy cannot always be used #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohamedAliSidibe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[GCI27] System.arraycopy cannot always be used #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ba9a50
[GCI27] System.arraycopy cannot always be used
May 20, 2026
c119b47
[GCI27] Edit changelog
May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Update ecocode-rules-specifications to 1.4.6

## [unreleased]
Copy link
Copy Markdown
Contributor

@jbureau92 jbureau92 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doublon with L8


### Changed

- #193 GCI27 - reduce false positives for System.arraycopy suggestions inside conditional and try/catch blocks
Copy link
Copy Markdown
Contributor

@jbureau92 jbureau92 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad Format


## [2.1.2] - 2026-05-20
Copy link
Copy Markdown
Contributor

@jbureau92 jbureau92 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doublon with L23


[unreleased](https://github.com/green-code-initiative/creedengo-java/compare/2.1.2...HEAD)
[2.1.2](https://github.com/green-code-initiative/creedengo-java/compare/2.1.1...2.1.2)
[2.1.1](https://github.com/green-code-initiative/creedengo-java/compare/2.1.0...2.1.1)
Expand Down
62 changes: 31 additions & 31 deletions ...ect/src/main/java/org/greencodeinitiative/creedengo/java/checks/GCI27/ArrayCopyCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,14 @@ public void copyWithForLoop() {
}

// Copy with nested conditions
for (int i = 0; i < len; i++) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (int i = 0; i < len; i++) {
if(i + 2 < len) {
dest[i] = src[i + 2];
}
}

// Copy with nested ELSE conditions
for (int i = 0; i < len; i++) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (int i = 0; i < len; i++) {
if(i + 2 >= len) {
i++;
} else {
Expand All @@ -86,7 +86,7 @@ public void copyWithForLoop() {
}

// Copy with more nested conditions
for (int i = 0; i < len; i++) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (int i = 0; i < len; i++) {
if(i + 2 < len) {
if(dest != null) {
if(src != null) {
Expand All @@ -99,7 +99,7 @@ public void copyWithForLoop() {
}

// Copy nested by try/catch
for (int i = 0; i < len; i++) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (int i = 0; i < len; i++) {
try {
dest[i] = src[i];
} catch (RuntimeException e) {
Expand All @@ -108,7 +108,7 @@ public void copyWithForLoop() {
}

// Copy nested by try/catch and if
for (int i = 0; i < len; i++) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (int i = 0; i < len; i++) {
try {
if(dest != null) {
dest[i] = src[i];
Expand All @@ -119,7 +119,7 @@ public void copyWithForLoop() {
}

// Copy nested by try/catch in catch
for (int i = 0; i < len; i++) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (int i = 0; i < len; i++) {
try {
dest.toString();
} catch (RuntimeException e) {
Expand All @@ -130,7 +130,7 @@ public void copyWithForLoop() {
}

// Copy nested by try/catch in finally
for (int i = 0; i < len; i++) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (int i = 0; i < len; i++) {
try {
dest.toString();
} catch (RuntimeException e) {
Expand Down Expand Up @@ -159,15 +159,15 @@ public void copyWithForEachLoop() {

// Copy with nested conditions by foreach
i = -1;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
if(b) {
dest[++i] = b;
}
}

// Copy with nested ELSE conditions by foreach
i = -1;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
if(i + 2 >= len) {
i++;
} else {
Expand All @@ -177,7 +177,7 @@ public void copyWithForEachLoop() {

// Copy with more nested conditions
i = -1;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
if(i + 2 < len) {
if(dest != null) {
if(src != null) {
Expand All @@ -191,7 +191,7 @@ public void copyWithForEachLoop() {

// Copy nested by try/catch
i = -1;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
try {
dest[++i] = b;
} catch (RuntimeException e) {
Expand All @@ -201,7 +201,7 @@ public void copyWithForEachLoop() {

// Copy nested by try/catch and if
i = -1;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
try {
if(dest != null) {
dest[++i] = b;
Expand All @@ -213,7 +213,7 @@ public void copyWithForEachLoop() {

// Copy nested by try/catch in catch
i = -1;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
try {
dest.toString();
} catch (RuntimeException e) {
Expand All @@ -225,7 +225,7 @@ public void copyWithForEachLoop() {

// Copy nested by try/catch in finally
i = -1;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
try {
dest.toString();
} catch (RuntimeException e) {
Expand All @@ -250,7 +250,7 @@ public void copyWithForEachLoop() {

// Copy with nested conditions
i = 0;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
if(b) {
dest[i] = src[i];
}
Expand All @@ -259,7 +259,7 @@ public void copyWithForEachLoop() {

// Copy with nested ELSE conditions
i = 0;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
if(i + 2 >= len) {
i++;
} else {
Expand All @@ -270,7 +270,7 @@ public void copyWithForEachLoop() {

// Copy with more nested conditions
i = 0;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
if(i + 2 < len) {
if(dest != null) {
if(src != null) {
Expand All @@ -285,7 +285,7 @@ public void copyWithForEachLoop() {

// Copy nested by try/catch
i = 0;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
try {
dest[i] = src[i];
} catch (RuntimeException e) {
Expand All @@ -296,7 +296,7 @@ public void copyWithForEachLoop() {

// Copy nested by try/catch and if
i = 0;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
try {
if(dest != null) {
dest[i] = src[i];
Expand All @@ -309,7 +309,7 @@ public void copyWithForEachLoop() {

// Copy nested by try/catch in catch
i = 0;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
try {
dest.toString();
} catch (RuntimeException e) {
Expand All @@ -322,7 +322,7 @@ public void copyWithForEachLoop() {

// Copy nested by try/catch in finally
i = 0;
for (boolean b : src) { // Noncompliant {{Use System.arraycopy to copy arrays}}
for (boolean b : src) {
try {
dest.toString();
} catch (RuntimeException e) {
Expand Down Expand Up @@ -355,7 +355,7 @@ public void copyWithWhileLoop() {

// Copy with nested conditions
i = 0;
while (i < len) { // Noncompliant {{Use System.arraycopy to copy arrays}}
while (i < len) {
if(i + 2 < len) {
dest[i] = src[i + 2];
}
Expand All @@ -364,7 +364,7 @@ public void copyWithWhileLoop() {

// Copy with nested ELSE conditions
i = 0;
while (i < len) { // Noncompliant {{Use System.arraycopy to copy arrays}}
while (i < len) {
if(i + 2 >= len) {
i++;
} else {
Expand All @@ -375,7 +375,7 @@ public void copyWithWhileLoop() {

// Copy with more nested conditions
i = 0;
while (i < len) { // Noncompliant {{Use System.arraycopy to copy arrays}}
while (i < len) {
if(i + 2 < len) {
if(dest != null) {
if(src != null) {
Expand All @@ -390,7 +390,7 @@ public void copyWithWhileLoop() {

// Copy nested by try/catch and if
i = 0;
while (i < len) { // Noncompliant {{Use System.arraycopy to copy arrays}}
while (i < len) {
try {
if(dest != null) {
dest[i] = src[i];
Expand All @@ -403,7 +403,7 @@ public void copyWithWhileLoop() {

// Copy nested by try/catch in catch
i = 0;
while (i < len) { // Noncompliant {{Use System.arraycopy to copy arrays}}
while (i < len) {
try {
dest.toString();
} catch (RuntimeException e) {
Expand Down Expand Up @@ -436,7 +436,7 @@ public void copyWithDoWhileLoop() {

// Copy with nested conditions
i = 0;
do { // Noncompliant {{Use System.arraycopy to copy arrays}}
do {
if(i + 2 < len) {
dest[i] = src[i + 2];
}
Expand All @@ -445,7 +445,7 @@ public void copyWithDoWhileLoop() {

// Copy with nested ELSE conditions
i = 0;
do { // Noncompliant {{Use System.arraycopy to copy arrays}}
do {
if(i + 2 >= len) {
i++;
} else {
Expand All @@ -456,7 +456,7 @@ public void copyWithDoWhileLoop() {

// Copy with more nested conditions
i = 0;
do { // Noncompliant {{Use System.arraycopy to copy arrays}}
do {
if(i + 2 < len) {
if(dest != null) {
if(src != null) {
Expand All @@ -471,7 +471,7 @@ public void copyWithDoWhileLoop() {

// Copy nested by try/catch and if
i = 0;
do { // Noncompliant {{Use System.arraycopy to copy arrays}}
do {
try {
if(dest != null) {
dest[i] = src[i];
Expand All @@ -484,7 +484,7 @@ public void copyWithDoWhileLoop() {

// Copy nested by try/catch in catch
i = 0;
do { // Noncompliant {{Use System.arraycopy to copy arrays}}
do {
try {
dest.toString();
} catch (RuntimeException e) {
Expand Down
49 changes: 6 additions & 43 deletions src/main/java/org/greencodeinitiative/creedengo/java/checks/ArrayCopyCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,15 @@
import org.sonar.plugins.java.api.tree.ArrayAccessExpressionTree;
import org.sonar.plugins.java.api.tree.AssignmentExpressionTree;
import org.sonar.plugins.java.api.tree.BlockTree;
import org.sonar.plugins.java.api.tree.CatchTree;
import org.sonar.plugins.java.api.tree.DoWhileStatementTree;
import org.sonar.plugins.java.api.tree.ExpressionStatementTree;
import org.sonar.plugins.java.api.tree.ExpressionTree;
import org.sonar.plugins.java.api.tree.ForEachStatement;
import org.sonar.plugins.java.api.tree.ForStatementTree;
import org.sonar.plugins.java.api.tree.IdentifierTree;
import org.sonar.plugins.java.api.tree.IfStatementTree;
import org.sonar.plugins.java.api.tree.StatementTree;
import org.sonar.plugins.java.api.tree.Tree;
import org.sonar.plugins.java.api.tree.Tree.Kind;
import org.sonar.plugins.java.api.tree.TryStatementTree;
import org.sonar.plugins.java.api.tree.VariableTree;
import org.sonar.plugins.java.api.tree.WhileStatementTree;
import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
Expand Down Expand Up @@ -180,61 +177,27 @@ private List<Bloc> getBlocsOfCode(final Tree tree) {
} else if (tree instanceof DoWhileStatementTree) {
DoWhileStatementTree castedDoWhileTree = (DoWhileStatementTree) tree;
addBloc(blocs, castedDoWhileTree.statement());
} else if (tree instanceof IfStatementTree) {
IfStatementTree castedIfTree = (IfStatementTree) tree;
addBloc(blocs, castedIfTree.thenStatement());
addBloc(blocs, castedIfTree.elseStatement());
} else if (tree instanceof TryStatementTree) {
final TryStatementTree tryTree = (TryStatementTree) tree;
addBloc(blocs, tryTree.block());
addBloc(blocs, extractCatchBlocks(tryTree));
addBloc(blocs, tryTree.finallyBlock());
}
return blocs;
}

/**
* Assignments extraction from block of code.
* Extract direct assignments from a block of code.
*
* @param tree
* @param block
* @return
* @param tree current tree
* @param bloc current block
* @return list of assignments
*/
private List<AssignmentExpressionTree> extractAssignments(final Tree tree, final Bloc bloc) {
final BlockTree block = bloc.getBlockTree();

// Prepare useful predicates
final Predicate<StatementTree> blocksPredicate = statement -> statement.is(Kind.IF_STATEMENT)
|| statement.is(Kind.TRY_STATEMENT);
final Predicate<StatementTree> assignmentPredicate = statement -> statement.is(Kind.EXPRESSION_STATEMENT)
&& ((ExpressionStatementTree) statement).expression().is(Kind.ASSIGNMENT);

// Filter expressions to find assignments
final List<AssignmentExpressionTree> result = block.body().stream().filter(assignmentPredicate)
return block.body().stream()
.filter(assignmentPredicate)
.map(assign -> (AssignmentExpressionTree) ((ExpressionStatementTree) assign).expression())
.collect(Collectors.toList());

// Recursive loop for nested blocks, add nested assignments to results
final List<StatementTree> ifStatements = block.body().stream().filter(blocksPredicate)
.collect(Collectors.toList());
for (final StatementTree ifstatement : ifStatements) {
final List<Bloc> blocs = getBlocsOfCode(ifstatement);
for (final Bloc b : blocs) {
result.addAll(extractAssignments(tree, b));
}
}
return result;
}

/**
* Extract all blocks of code from try/catch statement
*
* @param tryTree
* @return Array of StatementTree
*/
private BlockTree[] extractCatchBlocks(final TryStatementTree tryTree) {
final List<CatchTree> catches = tryTree.catches();
return catches.stream().map(CatchTree::block).collect(Collectors.toList()).toArray(new BlockTree[0]);
}

/**
Expand Down