[GCI27] System.arraycopy cannot always be used

[MohamedAliSidibe]

Description

This PR fixes false positives in rule GCI27 (Use System.arraycopy to copy arrays).

Previously, the rule analyzed nested assignments inside conditional and try/catch/finally blocks, which caused incorrect suggestions of System.arraycopy(...) for code performing filtering or conditional logic.

Example of previous false positive:

for (boolean b : src) {
    if (b) {
        dest[++i] = b;
    }
}

This pattern cannot be safely replaced by System.arraycopy because it performs conditional filtering instead of a direct array copy.

Changes

• Removed recursive extraction of nested assignments inside:

  • if
  • try
  • catch
  • finally

• The rule now analyzes only direct assignments located in the main loop block.

Result

The rule still detects valid direct array copy patterns such as:

for (int i = 0; i < src.length; i++) {
    dest[i] = src[i];
}

while avoiding false positives for conditional or transformed copies.

[MohamedAliSidibe]

Closes #19

[MohamedAliSidibe]

Mahamadou Ali Sidibe / LesShreks des dépendances moisies / CGI

[jbureau92]

Thank you for this PR! The logic change to avoid flagging array copies inside conditional and try/catch blocks is correct and well-tested.

Few fixes are needed in changelog, see inline comments.

GCIRulesIT.java is still configured to expect 36 issues at the old line numbers, which means the tests will fail

Nice to have: Branch coverage is 79.2% on ArrayCopyCheck (just below the 80% threshold). Adding one more test covering an uncovered branch path would push it over the threshold.

[jbureau92]

Doublon with L8

[jbureau92]

Doublon with L23

[jbureau92]

Bad Format