-
Notifications
You must be signed in to change notification settings - Fork 326
Enhancement/11459 User Engagement Selection Panel Notices #11884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jimmymadon
wants to merge
52
commits into
develop
Choose a base branch
from
enhancement/11459-user-engagement-selection-panel-notices
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
64b3322
Add the <AnalyticsDisconnectedNotice> to the User Settings Selection …
jimmymadon e5d1ac6
Add a story for the Analytics Disconnected state.
jimmymadon d75f3b9
Prevent storybook warnings for email reporting settings call.
jimmymadon 8e593cc
Add new story for analytics was never connected scenario.
jimmymadon 8c53227
Prevent errors in all stories for the UserSettingsSelectionPanel.
jimmymadon aaca6dd
Add the Setup Analytics Notice component.
jimmymadon 0c8669f
Update story names to be more descriptive.
jimmymadon c564347
Render the SetupAnalyticsNotice component.
jimmymadon 8121fcb
Remove unnecessary classname.
jimmymadon c1c9f9d
Add the Email Reporting disabled warning in selection panel for admins.
jimmymadon dfe10a9
Render the Email Reporting disabled warning in selection panel for ad…
jimmymadon 0902d2a
Add story for the Email Reporting disabled warning in selection panel…
jimmymadon 26d298a
Prevent analytics disconnected notices on all stories.
jimmymadon b9a4410
Prevent email reporting disabled warnings on all stories.
jimmymadon 8c746c7
Render the view-only version of Email Reporting disabled warning for …
jimmymadon 76e2b6c
Add the view-only version of Email Reporting disabled warning for adm…
jimmymadon 9861f5f
Add story for the view-only version of Email Reporting disabled warni…
jimmymadon caad782
Add view-only version of the AnalyticsDisconnectedNotice.
jimmymadon 6aa0430
Shorten story titles.
jimmymadon ef69922
Add story for view-only version of the Analytics Disconnected Notice.
jimmymadon 6f756ed
Move Email Reporting stories into the components namespace.
jimmymadon dcf054d
Wrap all notices into a single component.
jimmymadon d6ceec4
Move all notice components into a new Notices directory.
jimmymadon 85201d1
Standardise storybook titles.
jimmymadon f1700eb
Merge branch 'develop' into enhancement/11459-user-engagement-selecti…
jimmymadon 01de055
Fix receiveGetWasAnalytcs4Connected data object in Email Reporting st…
jimmymadon 4da3dac
Update VRT reference images.
jimmymadon 820baa5
Convert non-component folder to lowercase.
jimmymadon ac0b7e8
Move EmailReportingCardNotice to the notices folder.
jimmymadon ae2fd10
Move EmailReportingCardNotice.
jimmymadon ad62ee0
Temporarily delete the notices folder.
jimmymadon ded8edf
Temporarily delete the Notices component.
jimmymadon 070c09b
Temporarily remove unresolved components.
jimmymadon 3fd6445
Remove Notices temporarily.
jimmymadon 74c3079
Readd all notices.
jimmymadon 8b4a355
Re-add the Notices component.
jimmymadon 36ba30b
Re-add SettingsEmailReporting notices.
jimmymadon 9df579d
Add tests for SetupAnalyticsNotice component.
jimmymadon 2e8d3ba
Add test for view only state in AnalyticsDisconnectedNotice component.
jimmymadon c02292f
Refactor AnalyticsDisconnectedNotice test to simplify rendering and u…
jimmymadon b82d22c
Add tests for EmailReportingDisabledNotice component.
jimmymadon 2ed556d
Add tests for EmailReportingDisabledNotice component.
jimmymadon d5ff827
Add tests for EmailReportingDisabledViewOnlyNotice component.
jimmymadon 9977a04
Fix typo.
jimmymadon 1646e78
Remove string concatenation.
jimmymadon 1749ddf
Return undefined when the enabled setting is loading.
jimmymadon ea86cdf
Correct documentation.
jimmymadon 73a059f
Fix tests.
jimmymadon f321d62
Merge branch 'develop' into enhancement/11459-user-engagement-selecti…
jimmymadon cc7d38f
Add useViewOnly hook to SetupAnalyticsNotice component.
jimmymadon 84fe579
Enhance EmailReportingDisabledNotice to close settings panel on CTA c…
jimmymadon 6e733fb
Move incorrect import positioning.
jimmymadon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
41 changes: 41 additions & 0 deletions
41
assets/js/components/email-reporting/UserSettingsSelectionPanel/Notices.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /** | ||
| * User Settings Selection Notices | ||
| * | ||
| * Site Kit by Google, Copyright 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { Fragment } from '@wordpress/element'; | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import AnalyticsDisconnectedNotice from '@/js/components/email-reporting/notices/AnalyticsDisconnectedNotice'; | ||
| import EmailReportingDisabledNotice from '@/js/components/email-reporting/notices/EmailReportingDisabledNotice'; | ||
| import EmailReportingDisabledViewOnlyNotice from '@/js/components/email-reporting/notices/EmailReportingDisabledViewOnlyNotice'; | ||
| import SetupAnalyticsNotice from '@/js/components/email-reporting/notices/SetupAnalyticsNotice'; | ||
|
|
||
| export default function Notices() { | ||
| return ( | ||
| <Fragment> | ||
| <AnalyticsDisconnectedNotice /> | ||
| <SetupAnalyticsNotice /> | ||
| <EmailReportingDisabledNotice /> | ||
| <EmailReportingDisabledViewOnlyNotice /> | ||
| </Fragment> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.