Enhancement/11459 User Engagement Selection Panel Notices #11884
+816
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-panel-notices.
|
Storybook is ready:
|
|
Build files for 73a059f are ready:
|
|
Size Change: +2.87 kB (+0.13%) Total Size: 2.2 MB
ℹ️ View Unchanged
|
…pdate button presence check.
benbowler
requested changes
Dec 8, 2025
Collaborator
benbowler
left a comment
benbowler
left a comment
There was a problem hiding this comment.
Hey @jimmymadon, one bug and a couple of comments below.
In my testing the "Feature Disabled" notice is visible even when the feature is enabled on the main dashboard:
Screen.Recording.2025-12-08.at.13.49.57.mov
assets/js/components/email-reporting/notices/AnalyticsDisconnectedNotice.js
Show resolved
Hide resolved
assets/js/components/email-reporting/UserSettingsSelectionPanel/Notices.js
Show resolved
Hide resolved
| ).toBeInTheDocument(); | ||
| } ); | ||
|
|
||
| it( 'renders the "Conect Analytics" button and activates the module on click', async () => { |
Collaborator
There was a problem hiding this comment.
Suggested change
| it( 'renders the "Conect Analytics" button and activates the module on click', async () => { | |
| it( 'renders the "Connect Analytics" button and activates the module on click', async () => { |
benbowler
requested changes
Dec 9, 2025
Collaborator
There was a problem hiding this comment.
Hey @jimmymadon, a couple of points:
- This variant of the banner should be visible by admins only:
View-only users cannot activate analytics themselves, so in this state, no notice should be shown for view-only users.
- This wasn't caught in definition, however, when you are viewing the email reporting panel from within the settings and you see this variant, clicking "Edit Settings" should in fact close the panel.
Screen.Recording.2025-12-09.at.12.19.22.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
NoticeAreacomponent to the user engagement selection panel #11459Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist