-
Notifications
You must be signed in to change notification settings - Fork 248
GIDTokenClaim Implementation + Unit Tests #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AkshatG6
merged 3 commits into
gandhiakshat/sbc-auth_time
from
gandhiakshat/sbc-token_claim-object
Sep 5, 2025
+173
−0
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /* | ||
| * Copyright 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #import "GoogleSignIn/Sources/Public/GoogleSignIn/GIDTokenClaim.h" | ||
|
|
||
| NSString * const kAuthTimeClaimName = @"auth_time"; | ||
|
|
||
| // Private interface to declare the internal initializer | ||
| @interface GIDTokenClaim () | ||
|
|
||
| - (instancetype)initWithName:(NSString *)name | ||
| essential:(BOOL)essential NS_DESIGNATED_INITIALIZER; | ||
|
|
||
| @end | ||
|
|
||
| @implementation GIDTokenClaim | ||
|
|
||
| // Private designated initializer | ||
| - (instancetype)initWithName:(NSString *)name essential:(BOOL)essential { | ||
| self = [super init]; | ||
| if (self) { | ||
| _name = [name copy]; | ||
| _essential = essential; | ||
| } | ||
| return self; | ||
| } | ||
|
|
||
| #pragma mark - Factory Methods | ||
|
|
||
| + (instancetype)authTimeClaim { | ||
| return [[self alloc] initWithName:kAuthTimeClaimName essential:NO]; | ||
| } | ||
|
|
||
| + (instancetype)essentialAuthTimeClaim { | ||
| return [[self alloc] initWithName:kAuthTimeClaimName essential:YES]; | ||
| } | ||
|
|
||
| #pragma mark - NSObject | ||
|
|
||
| - (BOOL)isEqual:(id)object { | ||
| // 1. Check if the other object is the same instance in memory. | ||
| if (self == object) { | ||
| return YES; | ||
| } | ||
|
|
||
| // 2. Check if the other object is not a GIDTokenClaim instance. | ||
| if (![object isKindOfClass:[GIDTokenClaim class]]) { | ||
| return NO; | ||
| } | ||
|
|
||
| // 3. Compare the properties that define equality. | ||
| GIDTokenClaim *other = (GIDTokenClaim *)object; | ||
| return [self.name isEqualToString:other.name] && | ||
| self.isEssential == other.isEssential; | ||
| } | ||
|
|
||
| - (NSUInteger)hash { | ||
| // The hash value should be based on the same properties used in isEqual: | ||
| return self.name.hash ^ @(self.isEssential).hash; | ||
| } | ||
|
|
||
| @end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * Copyright 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #import <Foundation/Foundation.h> | ||
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| extern NSString *const kAuthTimeClaimName; | ||
|
|
||
| /** | ||
| * An object representing a single OIDC claim to be requested for an ID token. | ||
| */ | ||
| @interface GIDTokenClaim : NSObject | ||
|
|
||
| /// The name of the claim, e.g., "auth_time". | ||
| @property (nonatomic, readonly) NSString *name; | ||
|
|
||
| /// Whether the claim is requested as essential. | ||
| @property (nonatomic, readonly, getter=isEssential) BOOL essential; | ||
|
|
||
| // Making initializers unavailable to force use of factory methods. | ||
| - (instancetype)init NS_UNAVAILABLE; | ||
|
|
||
| #pragma mark - Factory Methods | ||
|
|
||
| /// Creates a *non-essential* (voluntary) "auth_time" claim object. | ||
| + (instancetype)authTimeClaim; | ||
AkshatG6 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /// Creates an *essential* "auth_time" claim object. | ||
| + (instancetype)essentialAuthTimeClaim; | ||
|
|
||
| @end | ||
|
|
||
| NS_ASSUME_NONNULL_END | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| // Copyright 2025 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
|
|
||
| #import <XCTest/XCTest.h> | ||
| #import "GoogleSignIn/Sources/Public/GoogleSignIn/GIDTokenClaim.h" | ||
|
|
||
| @interface GIDTokenClaimTest : XCTestCase | ||
mdmathias marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| @end | ||
|
|
||
| @implementation GIDTokenClaimTest | ||
|
|
||
| - (void)testAuthTimeClaim_PropertiesAreCorrect { | ||
| GIDTokenClaim *claim = [GIDTokenClaim authTimeClaim]; | ||
| XCTAssertEqualObjects(claim.name, kAuthTimeClaimName); | ||
| XCTAssertFalse(claim.isEssential); | ||
| } | ||
|
|
||
| - (void)testEssentialAuthTimeClaim_PropertiesAreCorrect { | ||
| GIDTokenClaim *claim = [GIDTokenClaim essentialAuthTimeClaim]; | ||
| XCTAssertEqualObjects(claim.name, kAuthTimeClaimName); | ||
| XCTAssertTrue(claim.isEssential); | ||
| } | ||
|
|
||
| - (void)testEquality_WithEqualClaims { | ||
| GIDTokenClaim *claim1 = [GIDTokenClaim authTimeClaim]; | ||
| GIDTokenClaim *claim2 = [GIDTokenClaim authTimeClaim]; | ||
| XCTAssertEqualObjects(claim1, claim2); | ||
| XCTAssertEqual(claim1.hash, claim2.hash); | ||
| } | ||
|
|
||
| - (void)testEquality_WithUnequalClaims { | ||
| GIDTokenClaim *claim1 = [GIDTokenClaim authTimeClaim]; | ||
| GIDTokenClaim *claim2 = [GIDTokenClaim essentialAuthTimeClaim]; | ||
| XCTAssertNotEqualObjects(claim1, claim2); | ||
| } | ||
|
|
||
| @end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.