GIDTokenClaim Implementation + Unit Tests #550
Merged
+173
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmathias
requested changes
Sep 4, 2025
|
|
||
| - (void)testAuthTimeClaim_PropertiesAreCorrect { | ||
| GIDTokenClaim *claim = [GIDTokenClaim authTimeClaim]; | ||
| XCTAssertEqualObjects(claim.name, @"auth_time"); |
Collaborator
There was a problem hiding this comment.
Perhaps useful to add string constants to GIDTokenClaim.h: kAuthTimeClaim. You could then compare to that here.
Contributor
Author
There was a problem hiding this comment.
I've added the string constant.
mdmathias
reviewed
Sep 4, 2025
| #import <XCTest/XCTest.h> | ||
| #import "GoogleSignIn/Sources/Public/GoogleSignIn/GIDTokenClaim.h" | ||
|
|
||
| static NSString *const kAuthTimeClaimName = @"auth_time"; |
Collaborator
There was a problem hiding this comment.
This should be declared in GIDTokenClaim.h, implemented and used in GIDTokenClaim.m
mdmathias
reviewed
Sep 4, 2025
mdmathias
approved these changes
Sep 5, 2025
AkshatG6
added a commit
that referenced
this pull request
Sep 9, 2025
This pull request introduces the `GIDTokenClaimsInternalOptions` class, a new component designed to handle the validation and JSON serialization of token claims. Key changes: * Adds the `GIDTokenClaimsInternalOptions` class to validate the token claims and return a JSON object. * Adds the `GIDJSONSerializer` protocol with real and fake implementations to support serializing the token claims. * Provides unit tests to validate the implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the
GIDTokenClaimclass, which allows for requesting specific OIDC claims for an ID token.Key changes:
GIDTokenClaimclass to represent a single OIDC claim.auth_timeclaims.