Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions pay_ios/ios/pay_ios.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,13 @@ Pod::Spec.new do |s|
DESC
s.homepage = 'https://github.com/google-pay/flutter-plugin'
s.license = { :file => '../LICENSE' }
s.author = { 'Google Pay Developer Relations' => 'payments-devrel-flutter@googlegroups.com
' }
s.author = { 'Google Pay Developer Relations' => 'payments-devrel-flutter@googlegroups.com' }
s.source = { :http => 'https://github.com/google-pay/flutter-plugin' }
s.source_files = 'Classes/**/*'
s.source_files = 'pay_ios/Sources/pay_ios/**/*'
s.dependency 'Flutter'
s.platform = :ios, '8.0'
s.platform = :ios, '13.0'
s.frameworks = 'PassKit'
# Flutter.framework does not contain a i386 slice.
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'i386' }
s.swift_version = '5.0'
end
end
19 changes: 19 additions & 0 deletions pay_ios/ios/pay_ios/Package.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// swift-tools-version: 5.9
import PackageDescription

let package = Package(
name: "pay_ios",
platforms: [
.iOS("13.0")
],
products: [
.library(name: "pay-ios", targets: ["pay_ios"])
],
dependencies: [],
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw in the blog post that the FlutterFramework should be added as a dependency. Will add that soon.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adopting step 10 of the migration guide (FlutterFramework dependency) would force a minimum-Flutter bump to 3.41, which is a breaking change for users still on 3.16–3.40:

environment:
  sdk: ^3.11.0
  flutter: ">=3.41.0"

Forcing the bump would block those users from upgrading to the SPM-enabled version of the plugin at all. They'd be stuck on the last pre-SPM release.

I'm not exactly sure if bumping is the right approach in this PR. We could do it later.
How would you proceed?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we release a major for this.

targets: [
.target(
name: "pay_ios",
dependencies: []
)
]
)