Skip to content

feat(pay_ios): Add Swift Package Manager support#327

Open
Robert-SD wants to merge 1 commit intogoogle-pay:mainfrom
Robert-SD:main
Open

feat(pay_ios): Add Swift Package Manager support#327
Robert-SD wants to merge 1 commit intogoogle-pay:mainfrom
Robert-SD:main

Conversation

@Robert-SD
Copy link
Copy Markdown
Collaborator

  • feat(pay_ios): add Swift Package Manager support

Describe the changes proposed

  • This PR introduces Swift Package Manager (SPM) support for the pay_ios component while keeping CocoaPods support via the existing podspec.
  • It also drops support for iOS 8-12 for apps consuming this plugin version. The latest Flutter version already targets iOS 13 as the minimum version. Would that breaking change be okay?

Screenshots / Videos

spm_support

@Robert-SD Robert-SD added the enhancement New feature or request label Apr 3, 2026
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 3, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Robert-SD Robert-SD changed the title Feature/swift package manager (#2) feat(pay_ios): Add Swift Package Manager support Apr 3, 2026
@johnpryan
Copy link
Copy Markdown

@Robert-SD could you please sign the CLA? Thank you!

* feat(pay_ios): add Swift Package Manager support

---------
@Robert-SD
Copy link
Copy Markdown
Collaborator Author

Hey @johnpryan, just did that! Thanks for the reminder. I changed the commit history and removed the bot from it.
Regarding the PR, would changing the minimum iOS version to 13 be okay?

products: [
.library(name: "pay-ios", targets: ["pay_ios"])
],
dependencies: [],
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw in the blog post that the FlutterFramework should be added as a dependency. Will add that soon.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adopting step 10 of the migration guide (FlutterFramework dependency) would force a minimum-Flutter bump to 3.41, which is a breaking change for users still on 3.16–3.40:

environment:
  sdk: ^3.11.0
  flutter: ">=3.41.0"

Forcing the bump would block those users from upgrading to the SPM-enabled version of the plugin at all. They'd be stuck on the last pre-SPM release.

I'm not exactly sure if bumping is the right approach in this PR. We could do it later.
How would you proceed?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we release a major for this.

@JlUgia JlUgia self-requested a review May 8, 2026 12:33
Copy link
Copy Markdown
Member

@JlUgia JlUgia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants