feat(pay_ios): Add Swift Package Manager support#327
feat(pay_ios): Add Swift Package Manager support#327Robert-SD wants to merge 1 commit intogoogle-pay:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@Robert-SD could you please sign the CLA? Thank you! |
* feat(pay_ios): add Swift Package Manager support ---------
|
Hey @johnpryan, just did that! Thanks for the reminder. I changed the commit history and removed the bot from it. |
| products: [ | ||
| .library(name: "pay-ios", targets: ["pay_ios"]) | ||
| ], | ||
| dependencies: [], |
There was a problem hiding this comment.
I saw in the blog post that the FlutterFramework should be added as a dependency. Will add that soon.
There was a problem hiding this comment.
Adopting step 10 of the migration guide (FlutterFramework dependency) would force a minimum-Flutter bump to 3.41, which is a breaking change for users still on 3.16–3.40:
environment:
sdk: ^3.11.0
flutter: ">=3.41.0"
Forcing the bump would block those users from upgrading to the SPM-enabled version of the plugin at all. They'd be stuck on the last pre-SPM release.
I'm not exactly sure if bumping is the right approach in this PR. We could do it later.
How would you proceed?
There was a problem hiding this comment.
I suggest we release a major for this.
Describe the changes proposed
Screenshots / Videos
