Skip to content

feat(gooddata-sdk): [AUTO] Add BASE_UI_ACCESS to organization permission test fixtures #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yenkins-admin wants to merge 1 commit into from
Closed

feat(gooddata-sdk): [AUTO] Add BASE_UI_ACCESS to organization permission test fixtures #1452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/gooddata-sdk/tests/catalog/expected/declarative_organization_permissions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,12 @@
"type": "userGroup"
},
"name": "SELF_CREATE_TOKEN"
},
{
"assignee": {
"id": "adminGroup",
"type": "userGroup"
},
"name": "BASE_UI_ACCESS"
}
]
7 changes: 6 additions & 1 deletion ...ages/gooddata-sdk/tests/catalog/fixtures/permissions/manage_organization_permissions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ interactions:
permissions:
- MANAGE
- SELF_CREATE_TOKEN
- BASE_UI_ACCESS
headers:
Accept-Encoding:
- br, gzip, deflate
Expand Down Expand Up @@ -67,7 +68,7 @@ interactions:
Cache-Control:
- no-cache, no-store, max-age=0, must-revalidate
Content-Length:
- '148'
- '223'
Content-Type:
- application/json
DATE: *id001
Expand Down Expand Up @@ -96,6 +97,10 @@ interactions:
id: adminGroup
type: userGroup
name: SELF_CREATE_TOKEN
- assignee:
id: adminGroup
type: userGroup
name: BASE_UI_ACCESS
- request:
method: PUT
uri: http://localhost:3000/api/v1/layout/organization/permissions
Expand Down
10 changes: 9 additions & 1 deletion ...data-sdk/tests/catalog/fixtures/permissions/put_declarative_organization_permissions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ interactions:
id: adminGroup
type: userGroup
name: SELF_CREATE_TOKEN
- assignee:
id: adminGroup
type: userGroup
name: BASE_UI_ACCESS
headers:
Accept-Encoding:
- br, gzip, deflate
Expand Down Expand Up @@ -69,7 +73,7 @@ interactions:
Cache-Control:
- no-cache, no-store, max-age=0, must-revalidate
Content-Length:
- '148'
- '223'
Content-Type:
- application/json
DATE: *id001
Expand Down Expand Up @@ -98,6 +102,10 @@ interactions:
id: adminGroup
type: userGroup
name: SELF_CREATE_TOKEN
- assignee:
id: adminGroup
type: userGroup
name: BASE_UI_ACCESS
- request:
method: PUT
uri: http://localhost:3000/api/v1/layout/organization/permissions
Expand Down
8 changes: 5 additions & 3 deletions packages/gooddata-sdk/tests/catalog/test_catalog_permission.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,11 +211,12 @@ def test_put_and_get_declarative_organization_permissions(test_config, snapshot_
sdk.catalog_permission.put_declarative_organization_permissions(declarative_organization_permissions)

catalog_declarative_permissions_after_put = sdk.catalog_permission.get_declarative_organization_permissions()
assert len(catalog_declarative_permissions_after_put) == 2
assert len(catalog_declarative_permissions_after_put) == 3
_assert_organization_permissions_id(catalog_declarative_permissions_after_put)
assert set(org_permission.name for org_permission in catalog_declarative_permissions_after_put) == {
"MANAGE",
"SELF_CREATE_TOKEN",
"BASE_UI_ACCESS",
}
finally:
safe_delete(_default_organization_permissions, sdk)
Expand All @@ -231,16 +232,17 @@ def test_manage_organization_permissions(test_config, snapshot_org_permissions):
[
CatalogOrganizationPermissionAssignment(
assignee_identifier=CatalogAssigneeIdentifier(id="adminGroup", type="userGroup"),
permissions=["MANAGE", "SELF_CREATE_TOKEN"],
permissions=["MANAGE", "SELF_CREATE_TOKEN", "BASE_UI_ACCESS"],
)
],
)

catalog_declarative_permissions_initial = sdk.catalog_permission.get_declarative_organization_permissions()
assert len(catalog_declarative_permissions_initial) == 2
assert len(catalog_declarative_permissions_initial) == 3
assert set(org_permission.name for org_permission in catalog_declarative_permissions_initial) == {
"MANAGE",
"SELF_CREATE_TOKEN",
"BASE_UI_ACCESS",
}
finally:
safe_delete(_default_organization_permissions, sdk)
Expand Down
Loading