feat(gooddata-sdk): [AUTO] Add BASE_UI_ACCESS to organization permission test fixtures#1452
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] Add BASE_UI_ACCESS to organization permission test fixtures#1452yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…ion test fixtures Updated test fixtures and assertions to include the new BASE_UI_ACCESS OrganizationPermission enum value (child of MANAGE) introduced in the auth-service and metadata-api OpenAPI specs (PR #20450 / STL-2322).
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1452 +/- ##
=======================================
Coverage 77.24% 77.24%
=======================================
Files 227 227
Lines 14672 14672
=======================================
Hits 11334 11334
Misses 3338 3338 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BASE_UI_ACCESS to organization permission test fixtures to align with regenerated API client.
Problem: P035 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862
Caution
Test fixtures were modified. Manually edited fixtures may not match real API responses.
Re-record these fixtures against a live server before merging:
packages/gooddata-sdk/tests/catalog/fixtures/permissions/put_declarative_organization_permissions.yamlpackages/gooddata-sdk/tests/catalog/fixtures/permissions/manage_organization_permissions.yamlWhat changed in gdc-nas
BASE_UI_ACCESStoOrganizationPermissionenum (child ofMANAGE) in both auth-service and metadata-api OpenAPI specs. AddedRESTRICT_BASE_UIboolean setting type (default false) with correspondingSettingConfiguration,WorkspaceSetting,UserSettingmodel updates, gRPC proto and Permissions extension updates.Related: STL-2322 | Merged via #20450
What was implemented in SDK
The API client was already regenerated and contains both
BASE_UI_ACCESS(OrganizationPermission) andRESTRICT_BASE_UI(setting type) in the relevant model files. SDK wrapper code does not hardcode enum values — validation delegates to the API client — so only test fixtures required updating.Updated test assertions to expect 3 permissions (
MANAGE,SELF_CREATE_TOKEN,BASE_UI_ACCESS) instead of 2, and updated VCR cassette YAML files to includeBASE_UI_ACCESSin request/response bodies.Files modified
packages/gooddata-sdk/tests/catalog/expected/declarative_organization_permissions.json— AddedBASE_UI_ACCESSto expected permissions listpackages/gooddata-sdk/tests/catalog/fixtures/permissions/put_declarative_organization_permissions.yaml— Updated cassette to includeBASE_UI_ACCESSin request/response bodiespackages/gooddata-sdk/tests/catalog/fixtures/permissions/manage_organization_permissions.yaml— Updated cassette to includeBASE_UI_ACCESSin request/response bodiespackages/gooddata-sdk/tests/catalog/test_catalog_permission.py— Updated assertions to expectBASE_UI_ACCESSJIRA: PENDING (Jira ticket will be created after review)
Risk: Low