fix: Bump cmake_minimum_required to 3.5 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last week CMake 4.0 released and it is in available in some bleeding edge distros like Arch Linux and it will be available in other distros soon. Compatibility with CMake < 3.5 has been removed from CMake 4.0. So we need to update the `VERSION` argument `<min>` value. Or, use the `<min>...<max>` syntax to tell CMake that the project requires at least `<min>` but has been updated to work with policies introduced by `<max>` or earlier. Or, we need add `-DCMAKE_POLICY_VERSION_MINIMUM=3.5` to cmake arguments to try configuring anyway. I changed `<min>` to `3.5`, so we can build with cmake >= 4.0. Signed-off-by: Ghorban M. Tavakoly <gmt3141@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last week CMake 4.0 released and it is in available in some bleeding edge distros like Arch Linux and it will be available in other distros soon.
Compatibility with CMake < 3.5 has been removed from CMake 4.0.
So we need to update the
VERSIONargument<min>value. Or, use the<min>...<max>syntax to tell CMake that the project requires at least<min>but has been updated to work with policies introduced by<max>or earlier.Or, we need add
-DCMAKE_POLICY_VERSION_MINIMUM=3.5to cmake arguments to try configuring anyway.I changed
<min>to3.5, so we can build with cmake >= 4.0.