fix: Replace SIGUNUSED with SIGSYS and use _GNU_SOURCE #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SIGUNUSED define was removed from glibc version 2.26 in August 2017. So Termistor cannot be built on GNU/Linux distributions that use glibc>=2.26, such as Fedora 27 and Ubuntu 17.10. From the [signal(7) man page](https://man7.org/linux/man-pages/man7/signal.7.html): ``` SIGUNUSED - Core Synonymous with SIGSYS ``` After changing `SIGUNSED` to `SIGSYS`, there are other problems raise while building the code: * `grantpt`, `unlockpt` and ptsname functions, needs `_XOPEN_SOURCE >= 500` feature test macro. * `posix_openpt` function needs `_XOPEN_SOURCE >= 600` feature test macro. * `pipe2` function needs `_GNU_SOURCE` feature test macro. Since `_GNU_SOURCE` implies nearly all feature test macros, adding `_GNU_SOURCE` is sufficient. Signed-off-by: Ghorban M. Tavakoly <gmt3141@gmail.com>
Author
|
Anyway, apparently this repo hasn't been updated in several years. I didn't realize this when I submitted this patch and the other one I submitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SIGUNUSEDdefine was removed from glibc version 2.26 in August 2017. So Termistor cannot be built on GNU/Linux distributions that use glibc>=2.26, such as Fedora>=27 and Ubuntu>=17.10.From the signal(7) man page:
After changing
SIGUNSEDtoSIGSYS, there are other problems raise while building the code:grantpt,unlockptandptsnamefunctions, need_XOPEN_SOURCE >= 500feature test macro.posix_openptfunction needs_XOPEN_SOURCE >= 600feature test macro.pipe2function needs_GNU_SOURCEfeature test macro.Since
_GNU_SOURCEimplies nearly all feature test macros, adding_GNU_SOURCEis sufficient.