Skip to content

REMOVE AGAIN: Introduce some mistakes that should be caught by QL4QL. #20308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelnebel wants to merge 2 commits into from
Closed

REMOVE AGAIN: Introduce some mistakes that should be caught by QL4QL. #20308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7416c9
REMOVE AGAIN: Introduce some mistakes that should be caught by QL4QL.
michaelnebel Aug 28, 2025
86adb51
REMOVE AGAIN: Add one more spelling error and modify the first line.
michaelnebel Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion csharp/ql/lib/semmle/code/csharp/exprs/Creation.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@
* }
* }
* ```
* Introduce a specific spelling error: abbout
Copy link

Copilot AI Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in the comment. 'abbout' should be 'about'.

Suggested change
* Introduce a specific spelling error: abbout
* Introduce a specific spelling error: about

Copilot uses AI. Check for mistakes.
*/
class ObjectCreation extends Call, LateBindableExpr, @object_creation_expr {
/** Gets the type of the newly created object. */
Expand Down Expand Up @@ -221,17 +222,18 @@
}
}

/**
/** Just modify the first line.
* An anonymous constructor call, for example
* `new { First = x[0], Last = x[x.Length - 1] }` on line 2 in
*
* ```csharp
* public IEnumerable<string> FirstLast(IEnumerable<string> list) {
* return list.Select(x => new { First = x[0], Last = x[x.Length - 1] }).
* Select(y => y.First + y.Last);
* }
* ```
* Introduce a specific spelling error: abbout
*/

Check warning

Code scanning / CodeQL

Misspelling Warning

This comment contains the common misspelling 'abbout', which should instead be 'about'.
class AnonymousObjectCreation extends ObjectCreation {
AnonymousObjectCreation() { this.getObjectType() instanceof AnonymousClass }

Expand All @@ -258,7 +260,14 @@

override string toString() { result = "delegate creation of type " + this.getType().getName() }
}

/**
* A delegate creation.
*
* Introduce a specific spelling error: abbout
*/
Comment on lines +264 to +268

Check warning

Code scanning / CodeQL

Misspelling Warning

This comment contains the common misspelling 'abbout', which should instead be 'about'.
class CommentDelegateCreation extends DelegateCreation { }

/**
* An explicit delegate creation, for example `new D(M)` on line 6 in
*
Expand Down
1 change: 0 additions & 1 deletion csharp/ql/src/Bad Practices/UseOfHtmlInputHidden.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
* @description Finds uses of hidden fields on forms
* @kind problem
* @problem.severity recommendation
* @security-severity 7.5
* @precision medium
* @id cs/web/html-hidden-input
* @tags security
Expand Down
Loading