REMOVE AGAIN: Introduce some mistakes that should be caught by QL4QL. #20308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
michaelnebel/testql4ql
branch
from
8f8e294 to
e7b90e1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces intentional mistakes for testing the QL4QL system, which is designed to catch quality issues in CodeQL queries and libraries. The changes include removing a security severity annotation from a query and adding a deliberate spelling error in a comment.
- Removes security-severity annotation from a CodeQL query
- Introduces a spelling error in library documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| csharp/ql/src/Bad Practices/UseOfHtmlInputHidden.ql | Removes the security-severity metadata annotation from the query |
| csharp/ql/lib/semmle/code/csharp/exprs/Creation.qll | Adds a deliberate spelling error in a comment |
| * } | ||
| * } | ||
| * ``` | ||
| * Introduce a specific spelling error: abbout |
There was a problem hiding this comment.
There is a spelling error in the comment. 'abbout' should be 'about'.
Suggested change
| * Introduce a specific spelling error: abbout | |
| * Introduce a specific spelling error: about |
michaelnebel
force-pushed
the
michaelnebel/testql4ql
branch
2 times, most recently
from
5e97057 to
bd9d1de
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+263
to
+268
| /** | ||
| * A delegate creation. | ||
| * | ||
| * Introduce a specific spelling error: abbout | ||
| */ |
Check warning
Code scanning / CodeQL
Misspelling Warning
michaelnebel
force-pushed
the
michaelnebel/testql4ql
branch
from
bd9d1de to
86adb51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.