Skip to content

Sanitize path when generating MaD files #18800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paldepind merged 1 commit into from
Feb 18, 2025
Merged

Sanitize path when generating MaD files #18800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions misc/scripts/models-as-data/generate_flow_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import subprocess
import sys
import tempfile
import re

def quote_if_needed(row):
if row != "true" and row != "false":
Expand Down Expand Up @@ -52,8 +53,8 @@ def printHelp(self):
--with-sources
--with-summaries
--with-neutrals
--with-mixed-summaries (Experimental). May not be used in conjunction with --with-summaries.
--with-mixed-neutrals (Experimental). Should only be used in conjunction with --with-mixed-summaries.
--with-mixed-summaries. May not be used in conjunction with --with-summaries.
--with-mixed-neutrals. Should only be used in conjunction with --with-mixed-summaries.
--with-typebased-summaries (Experimental)
If none of these flags are specified, all models are generated except for the type based models.

Expand All @@ -65,7 +66,7 @@ def printHelp(self):
$ python3 GenerateFlowModel.py /tmp/dbs/my_library_db --with-sinks my_directory


Requirements: `codeql` should both appear on your path.
Requirements: `codeql` should appear on your path.
""")


Expand Down Expand Up @@ -211,7 +212,9 @@ def save(self, extensions, extension):
extensions:
{0}"""
for entry in extensions:
target = os.path.join(self.generatedFrameworks, entry + extension)
# Replace problematic characters with dashes, and collapse multiple dashes.
sanitizedEntry = re.sub(r'-+', '-', entry.replace('/', '-').replace(':', '-'))
target = os.path.join(self.generatedFrameworks, sanitizedEntry + extension)
with open(target, "w") as f:
f.write(extensionTemplate.format(extensions[entry]))
print("Models as data extensions written to " + target)
Expand Down
Loading