Skip to content

Data flow: Add aliases for removing DataFlow prefixes #18682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 1 commit into from
Feb 5, 2025
Merged

Data flow: Add aliases for removing DataFlow prefixes #18682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions csharp/ql/test/library-tests/dataflow/delegates/DelegateFlow.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,19 @@ import semmle.code.csharp.dataflow.internal.DataFlowDispatch

query predicate delegateCall(DelegateLikeCall dc, Callable c) { c = dc.getARuntimeTarget() }

private class LocatableDataFlowCallOption extends DataFlowCallOption {
private class LocatableCallOption extends CallOption {
Location getLocation() {
this = TDataFlowCallNone() and
this = TCallNone() and
result instanceof EmptyLocation
or
exists(DataFlowCall call |
this = TDataFlowCallSome(call) and
this = TCallSome(call) and
result = call.getLocation()
)
}
}

private class LocatableDataFlowCall extends TDataFlowCall {
private class LocatableCall extends TDataFlowCall {
string toString() { result = this.(DataFlowCall).toString() }

Location getLocation() {
Expand All @@ -28,7 +28,7 @@ private class LocatableDataFlowCall extends TDataFlowCall {
}

query predicate viableLambda(
LocatableDataFlowCall call, LocatableDataFlowCallOption lastCall, DataFlowCallable target
LocatableCall call, LocatableCallOption lastCall, DataFlowCallable target
) {
target = viableCallableLambda(call, lastCall)
}
6 changes: 3 additions & 3 deletions csharp/ql/test/library-tests/dataflow/functionpointers/FunctionPointerFlow.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ import semmle.code.csharp.dataflow.internal.DataFlowDispatch

query predicate fptrCall(FunctionPointerCall dc, Callable c) { c = dc.getARuntimeTarget() }

private class LocatableDataFlowCallOption extends DataFlowCallOption {
private class LocatableDataFlowCallOption extends CallOption {
Location getLocation() {
this = TDataFlowCallNone() and
this = TCallNone() and
result instanceof EmptyLocation
or
exists(DataFlowCall call |
this = TDataFlowCallSome(call) and
this = TCallSome(call) and
result = call.getLocation()
)
}
Expand Down
Loading
Loading