Skip to content

Data flow: Add aliases for removing DataFlow prefixes #18682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hvitved merged 1 commit into from
Feb 5, 2025
Merged

Data flow: Add aliases for removing DataFlow prefixes #18682

hvitved merged 1 commit into from
Feb 5, 2025

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Feb 5, 2025 •
edited
Loading

Adds the following internal aliases in the data flow library to make the code less verbose

class Call = DataFlowCall;

class Callable = DataFlowCallable;

class Type = DataFlowType;

class Expr = DataFlowExpr;

@hvitved hvitved added the no-change-note-required This PR does not need a change note label Feb 5, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 5, 2025
View reviewed changes
shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll
default predicate reducedViableImplInCallContextCand(
DataFlowCall call, DataFlowCallable c, DataFlowCall ctx
) {
default predicate reducedViableImplInCallContextCand(Call call, Callable c, Call ctx) {

Check warning

Code scanning / CodeQL

Candidate predicate not marked as `nomagic` Warning

Candidate predicate to
reducedViableImplInCallContext
Loading
is not marked as nomagic.
Candidate predicate to
reducedViableImplInCallContext
Loading
is not marked as nomagic.
shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll
* returned to.
*/
default predicate reducedViableImplInReturnCand(DataFlowCallable c, DataFlowCall call) {
default predicate reducedViableImplInReturnCand(Callable c, Call call) {

Check warning

Code scanning / CodeQL

Candidate predicate not marked as `nomagic` Warning

Candidate predicate to
reducedViableImplInReturn
Loading
is not marked as nomagic.
Candidate predicate to
reducedViableImplInReturn
Loading
is not marked as nomagic.
@github-actions github-actions bot added the C# label Feb 5, 2025
@hvitved hvitved marked this pull request as ready for review February 5, 2025 12:14
@hvitved hvitved requested a review from a team as a code owner February 5, 2025 12:14
@hvitved hvitved requested a review from aschackmull February 5, 2025 12:14
aschackmull
aschackmull approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

michaelnebel
michaelnebel approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hvitved hvitved merged commit 9319b18 into github:main Feb 5, 2025
37 checks passed
@hvitved hvitved deleted the dataflow/aliases branch February 5, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelnebel michaelnebel michaelnebel approved these changes

@aschackmull aschackmull aschackmull approved these changes

Assignees

No one assigned

Labels

C# DataFlow Library no-change-note-required This PR does not need a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hvitved @michaelnebel @aschackmull