shared: Add locations to type tracking nodes #17787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoff
commented
Oct 17, 2024
python/ql/lib/semmle/python/dataflow/new/internal/TypeTrackingImpl.qll
Outdated
Show resolved
Hide resolved
yoff
changed the title
hvitved
reviewed
Jan 8, 2025
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
One comment, otherwise LGTM.
| /** Gets a textual representation of this node. */ | ||
| string toString(); | ||
|
|
||
| Location getLocation(); |
hvitved
approved these changes
Jan 8, 2025
Contributor
Author
|
Python timing changes are...negligible.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to debug type tracking.
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).