Powershell: Fix dataflow library after GitHub changes #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilanbhalla
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by two PRs on github/codeql:
On the GitHub side, it's the responsibility of the author of the changes to a shared library to make sure that the users of the shared library still works. However, as GitHub doesn't have PowerShell checks running in their CI it's not possible for them to do this. So we need to keep this up ourselves!
Luckily, such changes tend to be pretty trivial to fix. And indeed they are also easily fixable here.
Note that this PR will actually not work until we bump our own fork as above PRs haven't been merged into our fork yet.
cc @dilanbhalla