Skip to content

feat(k8s): add service_name label to k8s macro resources #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fpacifici wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(k8s): add service_name label to k8s macro resources #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sentry_streams_k8s/sentry_streams_k8s/pipeline_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,7 @@ def run(self, context: dict[str, Any]) -> dict[str, Any]:
labels = {
"pipeline-app": make_k8s_name(pipeline_module),
"pipeline": make_k8s_name(pipeline_name),
"service": make_k8s_name(service_name),
}
configmap_name = make_k8s_name(f"{service_name}-pipeline-{pipeline_name}")

Expand Down
5 changes: 5 additions & 0 deletions sentry_streams_k8s/tests/test_pipeline_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@ def test_run_generates_complete_manifests() -> None:
# Validate deployment name
assert deployment["metadata"]["name"] == "my-service-pipeline-profiles-0"
assert deployment["metadata"]["labels"]["pipeline-app"] == "sbc-profiles"
assert deployment["metadata"]["labels"]["service"] == "my-service"
assert (
deployment["spec"]["template"]["metadata"]["annotations"]["sidecar.istio.io/inject"]
== "false"
Expand All @@ -394,6 +395,7 @@ def test_run_generates_complete_manifests() -> None:
selector = deployment["spec"]["selector"]
assert selector["matchLabels"]["pipeline-app"] == "sbc-profiles"
assert selector["matchLabels"]["pipeline"] == "profiles"
assert selector["matchLabels"]["service"] == "my-service"

# Validate deployment has container
containers = deployment["spec"]["template"]["spec"]["containers"]
Expand All @@ -418,6 +420,7 @@ def test_run_generates_complete_manifests() -> None:
assert configmap["metadata"]["name"] == "my-service-pipeline-profiles"
assert configmap["metadata"]["labels"]["pipeline-app"] == "sbc-profiles"
assert configmap["metadata"]["labels"]["pipeline"] == "profiles"
assert configmap["metadata"]["labels"]["service"] == "my-service"

# Validate configmap data
assert "pipeline_config.yaml" in configmap["data"]
Expand Down Expand Up @@ -568,6 +571,7 @@ def test_run_with_base_templates() -> None:
# Check that pipeline additions are present
assert deployment["metadata"]["name"] == "my-service-pipeline-profiles-0"
assert "pipeline" in deployment["metadata"]["labels"]
assert "service" in deployment["metadata"]["labels"]
assert len(deployment["spec"]["template"]["spec"]["containers"]) == 1
assert (
len(deployment["spec"]["template"]["spec"]["volumes"]) == 2
Expand Down Expand Up @@ -1035,5 +1039,6 @@ def test_emergency_patch_overrides_final_deployment() -> None:
# Verify pipeline additions are still present (not removed by emergency patch)
assert deployment["metadata"]["name"] == "my-service-pipeline-profiles-0"
assert deployment["metadata"]["labels"]["pipeline-app"] == "sbc-profiles"
assert deployment["metadata"]["labels"]["service"] == "my-service"
assert len(deployment["spec"]["template"]["spec"]["containers"]) == 1
assert deployment["spec"]["template"]["spec"]["containers"][0]["name"] == "pipeline-consumer"
Loading