feat(k8s): add service_name label to k8s macro resources#255
Open
feat(k8s): add service_name label to k8s macro resources#255
Conversation
Add `service` label to the labels dict in `pipeline_step.py` so that Deployment and ConfigMap resources include the service name, enabling service-level monitoring, alerting, and discovery in Sentry's infrastructure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
servicelabel (set tomake_k8s_name(service_name)) to thelabelsdict inpipeline_step.pyspec.selector.matchLabels, pod template labels, and ConfigMap metadataservicelabel in affected test casesTest plan
test_run_generates_complete_manifests— assertsservicelabel on deployment metadata, selector matchLabels, and configmap metadatatest_run_emergency_patch_overrides— assertsservicelabel on deployment metadatatest_user_template_merged_with_base_template— assertsservicekey present in deployment labelstests/test_pipeline_step.pypass🤖 Generated with Claude Code