-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(ui): Update route error page with troubleshooting guide and support instructions #110687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -90,7 +90,6 @@ function RouteError({error, disableLogSentry, disableReport, project}: Props) { | |
| // Remove the report dialog on unmount | ||
| useEffect(() => () => document.querySelector('.sentry-error-embed-wrapper')?.remove()); | ||
|
|
||
| // TODO(dcramer): show additional resource links | ||
| return ( | ||
| <Alert.Container> | ||
| <Alert variant="danger" showIcon={false}> | ||
|
|
@@ -101,7 +100,9 @@ function RouteError({error, disableLogSentry, disableReport, project}: Props) { | |
| We use Sentry to monitor Sentry and it's likely we're already looking into this! | ||
| `)} | ||
| </p> | ||
| <p>{t("If you're daring, you may want to try the following:")}</p> | ||
| <p style={{marginBottom: 0}}> | ||
| {t("If you're daring, you may want to try the following:")} | ||
| </p> | ||
| <List symbol="bullet"> | ||
| {window?.adblockSuspected && ( | ||
| <ListItem> | ||
|
|
@@ -122,11 +123,35 @@ function RouteError({error, disableLogSentry, disableReport, project}: Props) { | |
| })} | ||
| </ListItem> | ||
| <ListItem> | ||
| {tct(`If all else fails, [link:contact us] with more details.`, { | ||
| link: ( | ||
| <ExternalLink href="https://github.com/getsentry/sentry/issues/new/choose" /> | ||
| ), | ||
| })} | ||
| {tct( | ||
| `Still stuck? Our [link:troubleshooting guide] has tips for common browser-related issues.`, | ||
| { | ||
| link: ( | ||
| <ExternalLink href="https://sentry.zendesk.com/hc/en-us/articles/22088541158555-Why-Sentry-io-is-not-loading" /> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does this make sense to show for self hosted
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, this is basic browser/plugin troubleshooting |
||
| ), | ||
| } | ||
| )} | ||
| </ListItem> | ||
| </List> | ||
| <p style={{marginTop: '1em', marginBottom: 0}}> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment |
||
| {tct( | ||
| `If the guide does not help, [link:contact support] — include as many of these details as you can:`, | ||
| { | ||
| link: <ExternalLink href="https://sentry.zendesk.com/hc/en-us" />, | ||
| } | ||
| )} | ||
| </p> | ||
| <List symbol="bullet"> | ||
| <ListItem>{t('Browser logs (console and network tab errors)')}</ListItem> | ||
| <ListItem> | ||
| {t( | ||
| 'Whether anyone else in your organization sees the same error on that page' | ||
| )} | ||
| </ListItem> | ||
| <ListItem>{t('Which browser(s) and version(s) you are using')}</ListItem> | ||
| <ListItem>{t('Whether the error is intermittent or consistent')}</ListItem> | ||
| <ListItem> | ||
| {t('Whether the error only appears on that page, or on other pages too')} | ||
| </ListItem> | ||
| </List> | ||
| </Alert> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure you want
marginBottom: 0here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
purely visual - it balances the appearance of the
<p>s with the<List>s