Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 32 additions & 7 deletions static/app/views/routeError.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ function RouteError({error, disableLogSentry, disableReport, project}: Props) {
// Remove the report dialog on unmount
useEffect(() => () => document.querySelector('.sentry-error-embed-wrapper')?.remove());

// TODO(dcramer): show additional resource links
return (
<Alert.Container>
<Alert variant="danger" showIcon={false}>
Expand All @@ -101,7 +100,9 @@ function RouteError({error, disableLogSentry, disableReport, project}: Props) {
We use Sentry to monitor Sentry and it's likely we're already looking into this!
`)}
</p>
<p>{t("If you're daring, you may want to try the following:")}</p>
<p style={{marginBottom: 0}}>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure you want marginBottom: 0 here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

purely visual - it balances the appearance of the <p>s with the <List>s

{t("If you're daring, you may want to try the following:")}
</p>
<List symbol="bullet">
{window?.adblockSuspected && (
<ListItem>
Expand All @@ -122,11 +123,35 @@ function RouteError({error, disableLogSentry, disableReport, project}: Props) {
})}
</ListItem>
<ListItem>
{tct(`If all else fails, [link:contact us] with more details.`, {
link: (
<ExternalLink href="https://github.com/getsentry/sentry/issues/new/choose" />
),
})}
{tct(
`Still stuck? Our [link:troubleshooting guide] has tips for common browser-related issues.`,
{
link: (
<ExternalLink href="https://sentry.zendesk.com/hc/en-us/articles/22088541158555-Why-Sentry-io-is-not-loading" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this make sense to show for self hosted

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is basic browser/plugin troubleshooting

),
}
)}
</ListItem>
</List>
<p style={{marginTop: '1em', marginBottom: 0}}>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment

{tct(
`If the guide does not help, [link:contact support] — include as many of these details as you can:`,
{
link: <ExternalLink href="https://sentry.zendesk.com/hc/en-us" />,
}
)}
</p>
<List symbol="bullet">
<ListItem>{t('Browser logs (console and network tab errors)')}</ListItem>
<ListItem>
{t(
'Whether anyone else in your organization sees the same error on that page'
)}
</ListItem>
<ListItem>{t('Which browser(s) and version(s) you are using')}</ListItem>
<ListItem>{t('Whether the error is intermittent or consistent')}</ListItem>
<ListItem>
{t('Whether the error only appears on that page, or on other pages too')}
</ListItem>
</List>
</Alert>
Expand Down
Loading