Skip to content

feat(Unity): Added is_main_thread to Unity context #104952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitsandfoxes merged 5 commits into from
Dec 15, 2025
Merged

feat(Unity): Added is_main_thread to Unity context #104952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd7336a
Promote context to tag
bitsandfoxes Dec 15, 2025
d6b32b3
Added the rest of the tags
bitsandfoxes Dec 15, 2025
f6f8c59
Keep it unity-only
bitsandfoxes Dec 15, 2025
7dd65a9
feat(contexts): Remove backend changes (moved to separate PR)
bitsandfoxes Dec 15, 2025
3c0a943
Added key to spec
bitsandfoxes Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions static/app/components/events/contexts/platformContext/unity.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const MOCK_UNITY_CONTEXT = {
copy_texture_support: 'Basic, Copy3D, DifferentTypes, TextureToRT, RTToTexture',
editor_version: '2022.1.23f1',
install_mode: 'Store',
is_main_thread: true,
rendering_threading_mode: 'LegacyJobified',
target_frame_rate: '-1',
// Extra data is still valid and preserved
Expand Down Expand Up @@ -45,6 +46,7 @@ describe('UnityContext', () => {
value: '2022.1.23f1',
},
{key: 'install_mode', subject: 'Install Mode', value: 'Store'},
{key: 'is_main_thread', subject: 'Is Main Thread', value: true},
{
key: 'rendering_threading_mode',
subject: 'Rendering Threading Mode',
Expand Down
6 changes: 6 additions & 0 deletions static/app/components/events/contexts/platformContext/unity.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ export function getUnityContextData({data}: {data: UnityContext}): KeyValueListD
subject: t('Install Mode'),
value: data.install_mode,
};
case UnityContextKey.IS_MAIN_THREAD:
return {
key: ctxKey,
subject: t('Is Main Thread'),
value: data.is_main_thread,
};
case UnityContextKey.RENDERING_THREADING_MODE:
return {
key: ctxKey,
Expand Down
2 changes: 2 additions & 0 deletions static/app/types/event.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,7 @@ export enum UnityContextKey {
COPY_TEXTURE_SUPPORT = 'copy_texture_support',
EDITOR_VERSION = 'editor_version',
INSTALL_MODE = 'install_mode',
IS_MAIN_THREAD = 'is_main_thread',
RENDERING_THREADING_MODE = 'rendering_threading_mode',
TARGET_FRAME_RATE = 'target_frame_rate',
}
Expand All @@ -537,6 +538,7 @@ export interface UnityContext {
[UnityContextKey.COPY_TEXTURE_SUPPORT]: string;
[UnityContextKey.EDITOR_VERSION]: string;
[UnityContextKey.INSTALL_MODE]: string;
[UnityContextKey.IS_MAIN_THREAD]: boolean;
[UnityContextKey.RENDERING_THREADING_MODE]: string;
[UnityContextKey.TARGET_FRAME_RATE]: string;
type: 'unity';
Expand Down
Loading