Skip to content

Conversation

@bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Dec 15, 2025

Extended the Unity context by is_main_thread (boolean).

@bitsandfoxes bitsandfoxes requested review from a team as code owners December 15, 2025 14:05
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Dec 15, 2025
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@codecov
Copy link

codecov bot commented Dec 15, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
43446 1 43445 251
View the top 1 failed test(s) by shortest run time
tests.sentry.event_manager.interfaces.test_contexts::test_unity
Stack Traces | 0.052s run time
#x1B[1m#x1B[.../event_manager/interfaces/test_contexts.py#x1B[0m:189: in test_unity
    make_ctx_snapshot(
#x1B[1m#x1B[.../event_manager/interfaces/test_contexts.py#x1B[0m:16: in inner
    insta_snapshot(
#x1B[1m#x1B[31mE   Failed: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#x1B[0m
#x1B[1m#x1B[31mE   Snapshot .../snapshots/test_contexts/test_unity.pysnap changed!#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Re-run pytest with SENTRY_SNAPSHOTS_WRITEBACK=new and then use 'make review-python-snapshots' to review.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Or: Use SENTRY_SNAPSHOTS_WRITEBACK=1 to update snapshots directly.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   --- #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   +++ #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   @@ -0,0 +1,15 @@#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   +errors: null#x1B[0m
#x1B[1m#x1B[31mE   +tags:#x1B[0m
#x1B[1m#x1B[31mE   +- - unity.install_mode#x1B[0m
#x1B[1m#x1B[31mE   +  - Store#x1B[0m
#x1B[1m#x1B[31mE   +- - unity.is_main_thread#x1B[0m
#x1B[1m#x1B[31mE   +  - 'yes'#x1B[0m
#x1B[1m#x1B[31mE   +to_json:#x1B[0m
#x1B[1m#x1B[31mE   +  unity:#x1B[0m
#x1B[1m#x1B[31mE   +    active_scene_name: MainScene#x1B[0m
#x1B[1m#x1B[31mE   +    editor_version: 2022.3.1f1#x1B[0m
#x1B[1m#x1B[31mE   +    install_mode: Store#x1B[0m
#x1B[1m#x1B[31mE   +    is_main_thread: true#x1B[0m
#x1B[1m#x1B[31mE   +    rendering_threading_mode: MultiThreaded#x1B[0m
#x1B[1m#x1B[31mE   +    target_frame_rate: '60'#x1B[0m
#x1B[1m#x1B[31mE   +    type: unity#x1B[0m
#x1B[1m#x1B[31mE   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@bitsandfoxes bitsandfoxes force-pushed the feat/unity-main-thread-tag branch from aeb8434 to 7dd65a9 Compare December 15, 2025 14:48
@bitsandfoxes bitsandfoxes changed the title feat(Unity): Promote unity.is_main_thread to tag feat(Unity): Added is_main_thread to Unity context Dec 15, 2025
@bitsandfoxes bitsandfoxes merged commit f972dc7 into master Dec 15, 2025
49 checks passed
@bitsandfoxes bitsandfoxes deleted the feat/unity-main-thread-tag branch December 15, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants