feat(cloudflare): Migrate to dataCollection#21237
Merged
Merged
Conversation
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2a7233e. Configure here.
chargome
requested review from
JPeer264,
andreiborza and
s1gr1d
and removed request for
a team
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
JPeer264
approved these changes
Jun 1, 2026
s1gr1d
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the Cloudflare SDK from
sendDefaultPiito the newdataCollectionspec, without changing default behavior (the breaking default flips are deferred to v11).request.ts: Passclient.getDataCollectionOptions()tohttpHeadersToSpanAttributesinstead of thesendDefaultPiiboolean. Header/cookie filtering is now driven by the resolveddataCollection.sdk.ts:requestDataIntegrationis configured fromdataCollection, but cookies are kept off by default (Cloudflare's historical behavior) unless the user opts in viasendDefaultPiiordataCollection.cookies. MarkedTODO(v11)to drop this gate and let cookies default on (denylist-filtered) per spec ([v11] Migrate cookie / requestData gating to dataCollection #21260).httpServer.ts:maxRequestBodySizecontinues to default to'medium'(bodies captured by default, matching the Node SDK and pre-migration behavior). MarkedTODO(v11)to gate body capture ondataCollection.httpBodies([v11] Gate incoming HTTP body capture ondataCollection.httpBodies#21258).Fixes #20934